From: Guillaume Nault <g.nault@alphalink.fr>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: James Chapman <jchapman@katalix.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] l2tp: Add protocol field decompression
Date: Sun, 16 Dec 2018 20:17:58 +0100 [thread overview]
Message-ID: <20181216191758.gosagnvrp6seqcdb@kdev> (raw)
In-Reply-To: <CAKaJLVtG=BiLHe=3X57hBgrrc-FrHG6C1vbq96wDqeWwrEP52w@mail.gmail.com>
On Sun, Dec 16, 2018 at 08:36:42PM +0200, Sam Protsenko wrote:
> Hi Guillaume,
>
> On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault <g.nault@alphalink.fr> wrote:
> >
> > If you all agree, can we please revert this patch and properly
> > implement PFC in ppp_generic.c?
>
> How about instead of reverting I will try to provide the patch
> extracting duplicated PFC code (from L2TP, PPTP, etc) to
> ppp_generic.c? This one fixes actual problem, and if we are going to
> add it to ppp_generic anyway, why not do it in one patch? I'm willing
> to do this work in next few days. Hope there is no rush with revert?
>
Hi Sam,
Yes, no problem. Thanks for taking care of that.
But please try to get the code ready before net-next gets closed.
Guillaume
prev parent reply other threads:[~2018-12-16 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:59 [PATCH] l2tp: Add protocol field decompression Sam Protsenko
2018-12-16 7:28 ` David Miller
2018-12-16 16:29 ` Guillaume Nault
2018-12-16 18:36 ` Sam Protsenko
2018-12-16 19:17 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216191758.gosagnvrp6seqcdb@kdev \
--to=g.nault@alphalink.fr \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).