From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: Re: [PATCH] l2tp: Add protocol field decompression Date: Sun, 16 Dec 2018 20:17:58 +0100 Message-ID: <20181216191758.gosagnvrp6seqcdb@kdev> References: <20181214175921.6859-1-semen.protsenko@linaro.org> <20181216162605.qn2jjbyb2bgcbxgq@kdev> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Chapman , "David S. Miller" , netdev@vger.kernel.org, Linux Kernel Mailing List To: Sam Protsenko Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Dec 16, 2018 at 08:36:42PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > > > If you all agree, can we please revert this patch and properly > > implement PFC in ppp_generic.c? > > How about instead of reverting I will try to provide the patch > extracting duplicated PFC code (from L2TP, PPTP, etc) to > ppp_generic.c? This one fixes actual problem, and if we are going to > add it to ppp_generic anyway, why not do it in one patch? I'm willing > to do this work in next few days. Hope there is no rush with revert? > Hi Sam, Yes, no problem. Thanks for taking care of that. But please try to get the code ready before net-next gets closed. Guillaume