From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers Date: Sun, 16 Dec 2018 21:00:26 +0100 Message-ID: <20181216200026.GA29825@lunn.ch> References: <20181215025035.26977-1-vivien.didelot@gmail.com> <20181215174849.GE5922@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vivien Didelot , netdev@vger.kernel.org, Chris Healy , "John W . Linville" To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:49604 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730780AbeLPUAp (ORCPT ); Sun, 16 Dec 2018 15:00:45 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > > Hi Florian, Vivien > > > > I was wondering about that. Having this all under 'dsa' seems too > > granular. It would be better if we could have 'mv88e6xxx', 'b53', > > 'ksz', etc. That might need a new DSA driver op to get the driver name > > which we then use for the slave? > > We could indeed do that, the other option would be return something > like: "dsa-mv88e6xxx" or "dsa-b53" in ethtool::get_drv_info() but this > might be breaking ABI since "dsa" has been commonly established for the > past 10 years or so. > > Changing things within ethtool is reasonably easy, but we probably need > to decide now whether kernel changes are requited to assist with > companion ethtool changes. Hi Florian, Vivien Using reg[3] is not very robust. Some of the other devices could have a value which happens to be a Marvell ID. As you said, driver="DSA" is well established, so we probably don't want to change that. We could use the version string. We currently don't have a value in it. It would a bit unusual, but actually kind of fits to have the mv88ex6xxx version, b53 version, ksz version, of DSA. Andrew