From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH net] qed: Fix an error code qed_ll2_start_xmit() Date: Mon, 17 Dec 2018 10:05:13 +0300 Message-ID: <20181217070513.GD12159@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: everest-linux-l2@cavium.com, "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Mintz@kadam, Yuval , Ariel Elior Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:43426 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbeLQHFb (ORCPT ); Mon, 17 Dec 2018 02:05:31 -0500 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: We accidentally deleted the code to set "rc = -ENOMEM;" and this patch adds it back. Fixes: d2201a21598a ("qed: No need for LL2 frags indication") Signed-off-by: Dan Carpenter --- I'm not totally sure about this patch. Please review it carefully. There are four callers of this function: qedi_data_avail(), qedf_xmit(), qedf_fcoe_send_vlan_req() and qedf_fip_send(). Only qedi_data_avail() checks the error code, and if it sees an error it calls kfree_skb(). drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index 504c8f71b61d..90afd514ffe1 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -2506,6 +2506,7 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb, if (unlikely(dma_mapping_error(&cdev->pdev->dev, mapping))) { DP_NOTICE(cdev, "Unable to map frag - dropping packet\n"); + rc = -ENOMEM; goto err; } -- 2.17.1