From: Stefano Brivio <sbrivio@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Arjan van de Ven <arjan@linux.intel.com>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
syzbot <syzbot+43f6755d1c2e62743468@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Josh Triplett <josh@joshtriplett.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: WARNING in __rcu_read_unlock
Date: Mon, 17 Dec 2018 19:21:21 +0100 [thread overview]
Message-ID: <20181217192121.64f34511@redhat.com> (raw)
In-Reply-To: <20181217162421.6d636ee5@redhat.com>
On Mon, 17 Dec 2018 16:24:21 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:
> On Mon, 17 Dec 2018 06:57:35 -0800
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> > fou, fou6: ICMP error handlers for FoU and GUE
>
> This:
>
> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
> index 0d0ad19ecb87..20a6de26d146 100644
> --- a/net/ipv4/fou.c
> +++ b/net/ipv4/fou.c
> @@ -1008,6 +1008,9 @@ static int gue_err_proto_handler(int proto, struct sk_buff *skb, u32 info)
> {
> const struct net_protocol *ipprot = rcu_dereference(inet_protos[proto]);
>
> + if (ipprot == IPPROTO_UDP)
^^^ proto, of course
> + return -EINVAL;
> +
> if (ipprot && ipprot->err_handler) {
> if (!ipprot->err_handler(skb, info))
> return 0;
>
--
Stefano
next prev parent reply other threads:[~2018-12-17 18:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000005e47a2057d0edc49@google.com>
[not found] ` <20181216190412.GE4170@linux.ibm.com>
2018-12-17 9:44 ` WARNING in __rcu_read_unlock Dmitry Vyukov
2018-12-17 11:29 ` Paul E. McKenney
2018-12-17 13:07 ` Dmitry Vyukov
2018-12-17 14:14 ` Arjan van de Ven
2018-12-17 14:40 ` Dmitry Vyukov
2018-12-17 14:49 ` Paul E. McKenney
2018-12-17 14:57 ` Eric Dumazet
2018-12-17 14:59 ` Stefano Brivio
2018-12-17 15:11 ` Dmitry Vyukov
2018-12-17 15:24 ` Stefano Brivio
2018-12-17 15:53 ` Dmitry Vyukov
2018-12-17 23:18 ` Stefano Brivio
2018-12-18 8:49 ` Dmitry Vyukov
2018-12-18 12:40 ` Stefano Brivio
2018-12-18 13:26 ` Dmitry Vyukov
2018-12-18 14:02 ` Paul E. McKenney
2018-12-18 14:12 ` Stefano Brivio
2018-12-18 16:05 ` Dmitry Vyukov
2018-12-19 4:12 ` Cong Wang
2018-12-17 18:21 ` Stefano Brivio [this message]
2018-12-17 18:45 ` Dmitry Vyukov
2018-12-17 19:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217192121.64f34511@redhat.com \
--to=sbrivio@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dvyukov@google.com \
--cc=eric.dumazet@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=syzbot+43f6755d1c2e62743468@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).