From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
Date: Mon, 17 Dec 2018 22:28:05 +0100 [thread overview]
Message-ID: <20181217212805.GF19725@lunn.ch> (raw)
In-Reply-To: <20181217210521.4462-1-vivien.didelot@gmail.com>
On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
>
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.
Hi Vivien.
I like this, but it is still not guaranteed to be unique between DSA
drivers.
I suppose once we do get a clash, we can add some extra heuristics.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-12-17 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 21:05 [PATCH] net: dsa: mv88e6xxx: set ethtool regs version Vivien Didelot
2018-12-17 21:28 ` Andrew Lunn [this message]
2018-12-17 22:12 ` Florian Fainelli
2018-12-18 7:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217212805.GF19725@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).