* [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
@ 2018-12-17 21:05 Vivien Didelot
2018-12-17 21:28 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vivien Didelot @ 2018-12-17 21:05 UTC (permalink / raw)
To: netdev; +Cc: f.fainelli, andrew, Vivien Didelot, Vivien Didelot
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Currently the ethtool_regs version is set to 0 for all DSA drivers.
Use this field to store the chip ID to simplify the pretty dump of
any interfaces registered by the "dsa" driver.
Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index b39e29feefa1..26fb14a7117d 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1125,7 +1125,7 @@ static void mv88e6xxx_get_regs(struct dsa_switch *ds, int port,
u16 *p = _p;
int i;
- regs->version = 0;
+ regs->version = chip->info->prod_num;
memset(p, 0xff, 32 * sizeof(u16));
--
2.19.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
2018-12-17 21:05 [PATCH] net: dsa: mv88e6xxx: set ethtool regs version Vivien Didelot
@ 2018-12-17 21:28 ` Andrew Lunn
2018-12-17 22:12 ` Florian Fainelli
2018-12-18 7:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2018-12-17 21:28 UTC (permalink / raw)
To: Vivien Didelot; +Cc: netdev, f.fainelli, Vivien Didelot
On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
>
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.
Hi Vivien.
I like this, but it is still not guaranteed to be unique between DSA
drivers.
I suppose once we do get a clash, we can add some extra heuristics.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
2018-12-17 21:05 [PATCH] net: dsa: mv88e6xxx: set ethtool regs version Vivien Didelot
2018-12-17 21:28 ` Andrew Lunn
@ 2018-12-17 22:12 ` Florian Fainelli
2018-12-18 7:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2018-12-17 22:12 UTC (permalink / raw)
To: Vivien Didelot, netdev; +Cc: andrew, Vivien Didelot
On December 17, 2018 1:05:21 PM PST, Vivien Didelot <vivien.didelot@gmail.com> wrote:
>From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
>Currently the ethtool_regs version is set to 0 for all DSA drivers.
>
>Use this field to store the chip ID to simplify the pretty dump of
>any interfaces registered by the "dsa" driver.
>
>Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
2018-12-17 21:05 [PATCH] net: dsa: mv88e6xxx: set ethtool regs version Vivien Didelot
2018-12-17 21:28 ` Andrew Lunn
2018-12-17 22:12 ` Florian Fainelli
@ 2018-12-18 7:29 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-12-18 7:29 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, f.fainelli, andrew, vivien.didelot
From: Vivien Didelot <vivien.didelot@gmail.com>
Date: Mon, 17 Dec 2018 16:05:21 -0500
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
>
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-18 7:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 21:05 [PATCH] net: dsa: mv88e6xxx: set ethtool regs version Vivien Didelot
2018-12-17 21:28 ` Andrew Lunn
2018-12-17 22:12 ` Florian Fainelli
2018-12-18 7:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).