From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version
Date: Mon, 17 Dec 2018 22:28:05 +0100
Message-ID: <20181217212805.GF19725@lunn.ch>
References: <20181217210521.4462-1-vivien.didelot@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Vivien Didelot <vivien.didelot@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:50817 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727004AbeLQV2H (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 17 Dec 2018 16:28:07 -0500
Content-Disposition: inline
In-Reply-To: <20181217210521.4462-1-vivien.didelot@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
> 
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.

Hi Vivien.

I like this, but it is still not guaranteed to be unique between DSA
drivers.

I suppose once we do get a clash, we can add some extra heuristics.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew