From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features
Date: Tue, 18 Dec 2018 10:39:52 +0100 [thread overview]
Message-ID: <20181218093952.GB8334@lunn.ch> (raw)
In-Reply-To: <98eb58fb-9ba2-e18b-cd9f-7afd632a9f0b@gmail.com>
On Tue, Dec 18, 2018 at 07:34:50AM +0100, Heiner Kallweit wrote:
> Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected,
> therefore it's not needed to define this manually in the driver.
> genphy_config_init() will remove 1Gbps from phydev->supported if
> not supported. Having said that PHY drivers for 100Mbps not
> calling genphy_config_init() still have to set the features field.
> As most PHY's are 1Gbps-capable let's use this as default.
Hi Heiner
I'm not sure i like this. Today most PHYs are 1G. But multi-gige PHYs
are starting to appear. In 5 years time, i expect most new PHYs will
be 2.5G and 5G capable, maybe 10G. We then end up with the odd
situation that 10M, 100M and 2.5G, 5G and 10G all need features, but 1G
not.
I would prefer to keep it consistent and always have a features.
Andrew
next prev parent reply other threads:[~2018-12-18 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 6:34 [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features Heiner Kallweit
2018-12-18 6:36 ` [PATCH net-next 1/2] " Heiner Kallweit
2018-12-18 6:39 ` [PATCH net-next 2/2] net: phy: remove feature definition from 1Gbps PHY drivers Heiner Kallweit
2018-12-18 9:39 ` Andrew Lunn [this message]
2018-12-18 18:09 ` [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features Heiner Kallweit
2018-12-19 5:46 ` David Miller
2018-12-19 9:21 ` Andrew Lunn
2018-12-19 19:30 ` Heiner Kallweit
2018-12-19 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218093952.GB8334@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).