From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431 Date: Tue, 18 Dec 2018 13:12:26 +0100 Message-ID: <20181218121226.GG11088@lunn.ch> References: <1545083090-31529-1-git-send-email-Bryan.Whitehead@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com To: Bryan Whitehead Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:51594 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbeLRMM3 (ORCPT ); Tue, 18 Dec 2018 07:12:29 -0500 Content-Disposition: inline In-Reply-To: <1545083090-31529-1-git-send-email-Bryan.Whitehead@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 17, 2018 at 04:44:50PM -0500, Bryan Whitehead wrote: > The LAN7431 uses an external phy, and it can be found anywhere in > the phy address space. This patch uses phy address 1 for LAN7430 > only. And searches all addresses otherwise. > > Signed-off-by: Bryan Whitehead > --- > drivers/net/ethernet/microchip/lan743x_main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c > index e8ca98c..1ba8ea0 100644 > --- a/drivers/net/ethernet/microchip/lan743x_main.c > +++ b/drivers/net/ethernet/microchip/lan743x_main.c > @@ -2719,8 +2719,9 @@ static int lan743x_mdiobus_init(struct lan743x_adapter *adapter) > snprintf(adapter->mdiobus->id, MII_BUS_ID_SIZE, > "pci-%s", pci_name(adapter->pdev)); > > - /* set to internal PHY id */ > - adapter->mdiobus->phy_mask = ~(u32)BIT(1); > + if ((adapter->csr.id_rev & ID_REV_ID_MASK_) == ID_REV_ID_LAN7430_) > + /* LAN7430 uses internal phy at address 1 */ > + adapter->mdiobus->phy_mask = ~(u32)BIT(1); Hi Bryan Does LAN7430 have an external MDIO bus as well as the internal one? Is there a possibility for a PHY at address 0? If not, you can probably just not have a mask at all. Andrew