From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver
Date: Wed, 19 Dec 2018 08:45:21 -0800 (PST)
Message-ID: <20181219.084521.1742003644237224676.davem@davemloft.net>
References: <1545190897-22622-1-git-send-email-Tristram.Ha@microchip.com>
        <20181219100532.GA2066@nanopsycho>
        <20181219160857.GA13878@amd>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: jiri@resnulli.us, Tristram.Ha@microchip.com,
        sergio.paracuellos@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com,
        marex@denx.de, dan.carpenter@oracle.com,
        vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org
To: pavel@denx.de
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:60968 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728707AbeLSQpX (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 19 Dec 2018 11:45:23 -0500
In-Reply-To: <20181219160857.GA13878@amd>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Pavel Machek <pavel@denx.de>
Date: Wed, 19 Dec 2018 17:08:57 +0100

> Hi!
> 
>> >+static int ksz_i2c_write32(struct ksz_device *dev, u32 reg, u32 value)
>> >+{
>> >+	value = cpu_to_be32(value);
>> >+	return ksz_i2c_write(dev, reg, &value, 4);
>> >+}
>> >+
>> >+static int ksz_i2c_get(struct ksz_device *dev, u32 reg, void *data, size_t len)
>> >+{
>> >+	return ksz_i2c_read(dev, reg, data, len);
>> >+}
>> >+
>> >+static int ksz_i2c_set(struct ksz_device *dev, u32 reg, void *data, size_t len)
>> >+{
>> >+	return ksz_i2c_write(dev, reg, data, len);
>> >+}
>> 
>> 
>> This header file makes no sense. Please move the functions into .c
> 
> No, that would make code bigger & slower.
> 
> It makes sense to me. But I'd add "inline" keyword to make the goal
> explicit.

Let the compiler decide in *.c files please.  That is our rule.