From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY_READY Date: Wed, 19 Dec 2018 16:20:09 -0800 (PST) Message-ID: <20181219.162009.1442218608345366100.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:41692 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728849AbeLTAUL (ORCPT ); Wed, 19 Dec 2018 19:20:11 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Wed, 19 Dec 2018 07:50:43 +0100 > PHY_HALTED and PHY_READY both are non-started states and quite similar. > Major difference is that phy_start() changes from PHY_HALTED to > PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). > > There's no guarantee that PHY registers are completely untouched when > waking up from power-down, e.g. after system suspend. Therefore it's > safer to reconfigure aneg also when starting from PHY_HALTED. This can > be achieved and state machine made simpler by making PHY_HALTED going > to PHY_READY after having stopped everything. Then the only way up is > over PHY_UP. As part of the change PHY_HALTED is renamed to PHY_HALT to > reflect that it is a transition state. > > After this change states PHY_RESUMING and PHY_CHANGELINK can be > removed. It looks like this series is still under discussion, so I'll hold on this until the discussion meets some kind of agreement or conclusion. Thanks.