From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Marcin Wojtas" <mw@semihalf.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
netdev <netdev@vger.kernel.org>,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Russell King - ARM Linux" <linux@armlinux.org.uk>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"nadavh@marvell.com" <nadavh@marvell.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Stefan Chulski" <stefanc@marvell.com>,
"David Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE
Date: Wed, 19 Dec 2018 03:11:16 +0000 [thread overview]
Message-ID: <20181219110546.63f68f4b@xhacker.debian> (raw)
In-Reply-To: <20181217083735.4c6599b3@windsurf>
On Mon, 17 Dec 2018 08:37:35 +0100 Thomas Petazzoni wrote:
> Hello Marcin,
>
> On Mon, 17 Dec 2018 00:25:58 +0100, Marcin Wojtas wrote:
>
> > Thanks. Indeed, the patch is valid as a fix for current version of SW
> > BM. However, because this concept is broken, I will rework it and
> > submit patch/patches some time early 2019.
>
> I know some people are working on XDP support in mvneta, and this work
> also needs to change parts of the memory allocation strategy in this
> driver. I'd suggest to get in touch with those folks. Antoine can give
> you the contact details, I don't have them off-hand. Or perhaps they
> will see this e-mail :-)
Great. So the problem of current memory allocation is seen, glad to
know reworking is going on.
Besides the memory waste, there's another issue with commit 7e47fd84b56b
it always allocates page, so the rx is mapped with dmap_map_page(), but
the unmap routine isn't updated, there's mismatch here.
thanks
next prev parent reply other threads:[~2018-12-19 3:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 12:56 [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE Marcin Wojtas
2018-12-12 2:48 ` Jisheng Zhang
2018-12-12 8:22 ` Marcin Wojtas
2018-12-12 9:25 ` Jisheng Zhang
2018-12-12 11:04 ` Marcin Wojtas
2018-12-16 20:41 ` David Miller
2018-12-16 23:25 ` Marcin Wojtas
2018-12-17 7:37 ` Thomas Petazzoni
2018-12-19 3:11 ` Jisheng Zhang [this message]
2018-12-19 9:24 ` Marcin Wojtas
2018-12-19 10:21 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219110546.63f68f4b@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).