From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] fix print_0xhex on 32 bit Date: Wed, 19 Dec 2018 14:02:18 -0800 Message-ID: <20181219140218.60d0cab7@xeon-e3> References: <20181210222701.7672-1-stephen@networkplumber.org> <5f7269b6-f53d-b9d3-96f7-b2f86ccf759e@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/C4moEJY.K7p1JX+KBX=6nRy"; protocol="application/pgp-signature" Cc: netdev@vger.kernel.org, dedeckeh@gmail.com To: Serhey Popovych Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:43178 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728064AbeLSWC1 (ORCPT ); Wed, 19 Dec 2018 17:02:27 -0500 Received: by mail-pg1-f193.google.com with SMTP id v28so10038483pgk.10 for ; Wed, 19 Dec 2018 14:02:27 -0800 (PST) In-Reply-To: <5f7269b6-f53d-b9d3-96f7-b2f86ccf759e@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: --Sig_/C4moEJY.K7p1JX+KBX=6nRy Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 19 Dec 2018 22:00:38 +0200 Serhey Popovych wrote: > Stephen Hemminger wrote: >=20 > > The argument to print_0xhex is converted to unsigned long long > > so the format string give for normal printout has to be some > > variant of %llx. Otherwise, bogus values will be printed on > > 32 bit platforms. =20 >=20 > Sorry it is too late and change is merged as commit 90c5c969f0b9 > ("fix print_0xhex on 32 bit") but I want to ask following: >=20 > $ printf '0x%llx !=3D %#llx\n' 0 0 > 0x0 !=3D 0 >=20 > So we potentially can get "tos 0" vs "tos 0x0" previously. Is that > expected and will not cause any compatibility problems? >=20 > It is clear that 0 is always zero, but some code may rely on 0x form > even for zero. What do you think? >=20 > Thanks. >=20 >=20 Hmm. that is a surprise. we can change back if it matters. Was just trying to be consistent. Since most code that scraps is going to = use strtoul(str, NULL, 16) it shouldn't matter. --Sig_/C4moEJY.K7p1JX+KBX=6nRy Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEn2/DRbBb5+dmuDyPgKd/YJXN5H4FAlwav+oACgkQgKd/YJXN 5H421Q//WN9qYA1PKDLrTYx5ejaS+YZ+EMNXYMi7oYVO8Mck8nnIQm5qPa2yXF3b OdqI9LFWW544hsLyrOb1vAIvJhcQlAg7oyQmliPAMToOd1G/asOFZChVhJUpK1T5 Eudno0VRQshweVzoujqICeLD10qPz2bpHUTScpKqGQz5/f9Me7TjnE1ELtwQ4UPL G48D3YD0JMuLAw5PE7OOlRKoVdBC/HhjxjJ+hQtnKYGD3wXgM9jeqGMOpKHLNWG7 9HDNilRgIxPBE62dJhlf4xfqQJ42r+juMEA1FZSjWTWcYnqkJktfSi2JnG0yt3em xouO/eMnRpTWMIymdNKeuwX6zNv28zjl8e+ptsSMiiMaRDlsuPJvBPeYke55dSbp YRRy254TPAWBxAVoejCn1PoTiClH5S46A6l4YhPntOGnZe4B/9c1zgC2Qbn65Mq8 grqyeMuYpHX1sByBRtjZBKG0TRl8eSEleSwslq81qiIJS3QUpLd5xKccO9W3v02S WxCSVbxOG+GC/YJ4UV1IlXJPPExvoDFPuSDwjapdf1FTb65ioB5DuyaCdtaa+syX IkwtqIzk02A9em9WNq86mcv/ULv5lxOdtHfbZEiT5NU4Qar2qa5RF3sscoXlDCld +auv/RW9NHfGrCBFvJMVpFmawDD5ha3I1yoLP1gbwYLaNB4rYA0= =hrGo -----END PGP SIGNATURE----- --Sig_/C4moEJY.K7p1JX+KBX=6nRy--