[PATCH rdma-next 0/2] Fix to mlx5 devx interface

[PATCH rdma-next 0/2] Fix to mlx5 devx interface

[Leon Romanovsky]

From: Leon Romanovsky <leonro@mellanox.com>

Hi,

This small fix to mlx5 devx interface is separated to two, so we can
apply first patch to mlx5-next.

Thanks

Yishai Hadas (2):
  IB/mlx5: Introduce uid as part of alloc/dealloc transport domain
  IB/mlx5: Use uid as part of alloc/dealloc transport domain

 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 include/linux/mlx5/mlx5_ifc.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

[PATCH mlx5-next 1/2] IB/mlx5: Introduce uid as part of alloc/dealloc transport domain

[Leon Romanovsky]

From: Yishai Hadas <yishaih@mellanox.com>

Introduce uid as part of alloc/dealloc transport domain to match the
device specification.

Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Reviewed-by: Artemy Kovalyov <artemyko@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 include/linux/mlx5/mlx5_ifc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 15093356a226..61368ec2d295 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -6593,7 +6593,7 @@ struct mlx5_ifc_dealloc_transport_domain_out_bits {
 
 struct mlx5_ifc_dealloc_transport_domain_in_bits {
 	u8         opcode[0x10];
-	u8         reserved_at_10[0x10];
+	u8         uid[0x10];
 
 	u8         reserved_at_20[0x10];
 	u8         op_mod[0x10];
@@ -7446,7 +7446,7 @@ struct mlx5_ifc_alloc_transport_domain_out_bits {
 
 struct mlx5_ifc_alloc_transport_domain_in_bits {
 	u8         opcode[0x10];
-	u8         reserved_at_10[0x10];
+	u8         uid[0x10];
 
 	u8         reserved_at_20[0x10];
 	u8         op_mod[0x10];
-- 
2.19.1

[PATCH rdma-next 2/2] IB/mlx5: Use uid as part of alloc/dealloc transport domain

[Leon Romanovsky]

From: Yishai Hadas <yishaih@mellanox.com>

Use uid as part of alloc/dealloc transport domain to let firmware
manages the resources correctly.

Fixes: d2d19121ae2f("IB/mlx5: Set uid as part of TD commands)
Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Reviewed-by: Artemy Kovalyov <artemyko@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/infiniband/hw/mlx5/cmd.c b/drivers/infiniband/hw/mlx5/cmd.c
index 752c60426a1c..356bccc715ee 100644
--- a/drivers/infiniband/hw/mlx5/cmd.c
+++ b/drivers/infiniband/hw/mlx5/cmd.c
@@ -240,6 +240,7 @@ int mlx5_cmd_alloc_transport_domain(struct mlx5_core_dev *dev, u32 *tdn,
 
 	MLX5_SET(alloc_transport_domain_in, in, opcode,
 		 MLX5_CMD_OP_ALLOC_TRANSPORT_DOMAIN);
+	MLX5_SET(alloc_transport_domain_in, in, uid, uid);
 
 	err = mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
 	if (!err)
@@ -257,6 +258,7 @@ void mlx5_cmd_dealloc_transport_domain(struct mlx5_core_dev *dev, u32 tdn,
 
 	MLX5_SET(dealloc_transport_domain_in, in, opcode,
 		 MLX5_CMD_OP_DEALLOC_TRANSPORT_DOMAIN);
+	MLX5_SET(dealloc_transport_domain_in, in, uid, uid);
 	MLX5_SET(dealloc_transport_domain_in, in, transport_domain, tdn);
 	mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
 }
-- 
2.19.1

Re: [PATCH rdma-next 0/2] Fix to mlx5 devx interface

[Jason Gunthorpe]

On Wed, Dec 19, 2018 at 04:28:09PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Hi,
> 
> This small fix to mlx5 devx interface is separated to two, so we can
> apply first patch to mlx5-next.
> 
> Thanks
> 
> Yishai Hadas (2):
>   IB/mlx5: Introduce uid as part of alloc/dealloc transport domain
>   IB/mlx5: Use uid as part of alloc/dealloc transport domain
> 
>  drivers/infiniband/hw/mlx5/cmd.c | 2 ++
>  include/linux/mlx5/mlx5_ifc.h    | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)

These look fine too, please update the shared branch

Thanks,
Jason

Re: [PATCH rdma-next 0/2] Fix to mlx5 devx interface

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Wed, Dec 19, 2018 at 07:14:38PM +0000, Jason Gunthorpe wrote:
> On Wed, Dec 19, 2018 at 04:28:09PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Hi,
> >
> > This small fix to mlx5 devx interface is separated to two, so we can
> > apply first patch to mlx5-next.
> >
> > Thanks
> >
> > Yishai Hadas (2):
> >   IB/mlx5: Introduce uid as part of alloc/dealloc transport domain
> >   IB/mlx5: Use uid as part of alloc/dealloc transport domain
> >
> >  drivers/infiniband/hw/mlx5/cmd.c | 2 ++
> >  include/linux/mlx5/mlx5_ifc.h    | 4 ++--
> >  2 files changed, 4 insertions(+), 2 deletions(-)
>
> These look fine too, please update the shared branch

Done, thanks
71bef2fd583b IB/mlx5: Introduce uid as part of alloc/dealloc transport domain


>
> Thanks,
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH rdma-next 0/2] Fix to mlx5 devx interface

[Jason Gunthorpe]

On Wed, Dec 19, 2018 at 04:28:09PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Hi,
> 
> This small fix to mlx5 devx interface is separated to two, so we can
> apply first patch to mlx5-next.
> 
> Thanks
> 
> Yishai Hadas (2):
>   IB/mlx5: Introduce uid as part of alloc/dealloc transport domain
>   IB/mlx5: Use uid as part of alloc/dealloc transport domain
> 
>  drivers/infiniband/hw/mlx5/cmd.c | 2 ++
>  include/linux/mlx5/mlx5_ifc.h    | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)

Applied to for-next

Thanks,
Jason