From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver
Date: Wed, 19 Dec 2018 17:15:32 +0100
Message-ID: <20181219161532.GA2224@nanopsycho>
References: <1545190897-22622-1-git-send-email-Tristram.Ha@microchip.com>
 <20181219100532.GA2066@nanopsycho>
 <20181219160857.GA13878@amd>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Tristram.Ha@microchip.com,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Marek Vasut <marex@denx.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org
To: Pavel Machek <pavel@denx.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f65.google.com ([209.85.128.65]:54080 "EHLO
        mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727844AbeLSQXL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 19 Dec 2018 11:23:11 -0500
Received: by mail-wm1-f65.google.com with SMTP id d15so6674430wmb.3
        for <netdev@vger.kernel.org>; Wed, 19 Dec 2018 08:23:10 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181219160857.GA13878@amd>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Dec 19, 2018 at 05:08:57PM CET, pavel@denx.de wrote:
>Hi!
>
>> >+static int ksz_i2c_write32(struct ksz_device *dev, u32 reg, u32 value)
>> >+{
>> >+	value = cpu_to_be32(value);
>> >+	return ksz_i2c_write(dev, reg, &value, 4);
>> >+}
>> >+
>> >+static int ksz_i2c_get(struct ksz_device *dev, u32 reg, void *data, size_t len)
>> >+{
>> >+	return ksz_i2c_read(dev, reg, data, len);
>> >+}
>> >+
>> >+static int ksz_i2c_set(struct ksz_device *dev, u32 reg, void *data, size_t len)
>> >+{
>> >+	return ksz_i2c_write(dev, reg, data, len);
>> >+}
>> 
>> 
>> This header file makes no sense. Please move the functions into .c
>
>No, that would make code bigger & slower.
>
>It makes sense to me. But I'd add "inline" keyword to make the goal
>explicit.

1) It makes no sense to have header files for things like this. The
   functions are only used within the single .c file.

2) You cannot inline them, as they are used as ops.

>
>								Pavel
>-- 
>DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany