Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

On Wed 2018-12-19 17:15:32, Jiri Pirko wrote:
> Wed, Dec 19, 2018 at 05:08:57PM CET, pavel@denx.de wrote:
> >Hi!
> >
> >> >+static int ksz_i2c_write32(struct ksz_device *dev, u32 reg, u32 value)
> >> >+{
> >> >+	value = cpu_to_be32(value);
> >> >+	return ksz_i2c_write(dev, reg, &value, 4);
> >> >+}
> >> >+
> >> >+static int ksz_i2c_get(struct ksz_device *dev, u32 reg, void *data, size_t len)
> >> >+{
> >> >+	return ksz_i2c_read(dev, reg, data, len);
> >> >+}
> >> >+
> >> >+static int ksz_i2c_set(struct ksz_device *dev, u32 reg, void *data, size_t len)
> >> >+{
> >> >+	return ksz_i2c_write(dev, reg, data, len);
> >> >+}
> >> 
> >> 
> >> This header file makes no sense. Please move the functions into .c
> >
> >No, that would make code bigger & slower.
> >
> >It makes sense to me. But I'd add "inline" keyword to make the goal
> >explicit.
> 
> 1) It makes no sense to have header files for things like this. The
>    functions are only used within the single .c file.
> 
> 2) You cannot inline them, as they are used as ops.

Ok, sorry for the noise.
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]