From: Kalle Valo <kvalo@codeaurora.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: pkshih@realtek.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: Re: [PATCH] rtlwifi: Fix non-working BSS STA mode
Date: Thu, 20 Dec 2018 06:42:09 +0000 (UTC) [thread overview]
Message-ID: <20181220064209.E5AD9606FC@smtp.codeaurora.org> (raw)
In-Reply-To: <20181212051335.22580-1-kai.heng.feng@canonical.com>
Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> Once BSS STA mode gets started, it can be scanned by other clients but
> cannot entablish a connection.
>
> Turns out the set_bcn_reg() and its *_set_beacon_related_registers()
> callbacks never get called so it has problem beaconing.
>
> Enable the function in rtl_op_bss_info_changed() can make BSS STA mode
> start to work.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
The commit log is quite misleading. It implies that the client mode is broken
for all rtlwifi hardware and that can't be the case, otherwise we would be
flooded by bug reports. So please improve the commit log and describe clearly
the problem you are solving.
--
https://patchwork.kernel.org/patch/10725537/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-12-20 6:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 5:13 [PATCH] rtlwifi: Fix non-working BSS STA mode Kai-Heng Feng
2018-12-13 0:35 ` Pkshih
2018-12-13 5:36 ` Kai Heng Feng
2018-12-13 7:39 ` Pkshih
2018-12-13 8:03 ` Kai Heng Feng
2018-12-20 6:42 ` Kalle Valo [this message]
2018-12-20 12:56 ` Kai Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220064209.E5AD9606FC@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).