* [PATCH v2 net] mscc: Configured MAC entries should be locked.
@ 2018-12-20 8:37 Steen Hegelund
2018-12-20 10:28 ` Andrew Lunn
2018-12-21 0:23 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Steen Hegelund @ 2018-12-20 8:37 UTC (permalink / raw)
To: netdev, davem; +Cc: Allan W. Nielsen, Steen Hegelund
From: "Allan W. Nielsen" <allan.nielsen@microchip.com>
The MAC table in Ocelot supports auto aging (normal) and static entries.
MAC entries that is manually configured should be static and not subject
to aging.
Signed-off-by: Allan Nielsen <allan.nielsen@microchip.com>
Reviewed-by: Steen Hegelund <steen.hegelund@microchip.com>
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
drivers/net/ethernet/mscc/ocelot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 3238b9ee42f3..c84074fa4c95 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -747,7 +747,7 @@ static int ocelot_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
}
return ocelot_mact_learn(ocelot, port->chip_port, addr, vid,
- ENTRYTYPE_NORMAL);
+ ENTRYTYPE_LOCKED);
}
static int ocelot_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net] mscc: Configured MAC entries should be locked.
2018-12-20 8:37 [PATCH v2 net] mscc: Configured MAC entries should be locked Steen Hegelund
@ 2018-12-20 10:28 ` Andrew Lunn
2018-12-21 0:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-12-20 10:28 UTC (permalink / raw)
To: Steen Hegelund; +Cc: netdev, davem, Allan W. Nielsen
On Thu, Dec 20, 2018 at 09:37:17AM +0100, Steen Hegelund wrote:
> From: "Allan W. Nielsen" <allan.nielsen@microchip.com>
>
> The MAC table in Ocelot supports auto aging (normal) and static entries.
> MAC entries that is manually configured should be static and not subject
> to aging.
>
> Signed-off-by: Allan Nielsen <allan.nielsen@microchip.com>
> Reviewed-by: Steen Hegelund <steen.hegelund@microchip.com>
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 net] mscc: Configured MAC entries should be locked.
2018-12-20 8:37 [PATCH v2 net] mscc: Configured MAC entries should be locked Steen Hegelund
2018-12-20 10:28 ` Andrew Lunn
@ 2018-12-21 0:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-12-21 0:23 UTC (permalink / raw)
To: steen.hegelund; +Cc: netdev, allan.nielsen
From: Steen Hegelund <steen.hegelund@microchip.com>
Date: Thu, 20 Dec 2018 09:37:17 +0100
> From: "Allan W. Nielsen" <allan.nielsen@microchip.com>
>
> The MAC table in Ocelot supports auto aging (normal) and static entries.
> MAC entries that is manually configured should be static and not subject
> to aging.
>
> Signed-off-by: Allan Nielsen <allan.nielsen@microchip.com>
> Reviewed-by: Steen Hegelund <steen.hegelund@microchip.com>
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 0:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 8:37 [PATCH v2 net] mscc: Configured MAC entries should be locked Steen Hegelund
2018-12-20 10:28 ` Andrew Lunn
2018-12-21 0:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).