From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net] mscc: Register poll timeout should be wall time not attempts Date: Thu, 20 Dec 2018 11:31:50 +0100 Message-ID: <20181220103150.GD13180@lunn.ch> References: <20181220090816.12764-1-steen.hegelund@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, alexandre.belloni@bootlin.com To: Steen Hegelund Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:54112 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727502AbeLTKbv (ORCPT ); Thu, 20 Dec 2018 05:31:51 -0500 Content-Disposition: inline In-Reply-To: <20181220090816.12764-1-steen.hegelund@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Dec 20, 2018 at 10:08:16AM +0100, Steen Hegelund wrote: > When doing indirect access in the Ocelot chip, a command is setup, > issued and then we need to poll until the result is ready. The polling > timeout is specified in milliseconds in the datasheet and not in > register access attempts. > > Signed-off-by: Steen Hegelund Hi Steen Have you seen real issues with this code? You have marked this for net, indicating it is a bug fix. If it is a real fix, please provide a fixes: tag. Thanks Andrew