From: Andrew Lunn <andrew@lunn.ch>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net] mscc: Register poll timeout should be wall time not attempts
Date: Thu, 20 Dec 2018 12:31:11 +0100 [thread overview]
Message-ID: <20181220113111.GE13180@lunn.ch> (raw)
In-Reply-To: <20181220111149.ht4nt7jtgilysnk7@soft-dev13.dk.vitesse.com>
On Thu, Dec 20, 2018 at 12:11:50PM +0100, Steen Hegelund wrote:
> The 12/20/2018 11:31, Andrew Lunn wrote:
> > On Thu, Dec 20, 2018 at 10:08:16AM +0100, Steen Hegelund wrote:
> > > When doing indirect access in the Ocelot chip, a command is setup,
> > > issued and then we need to poll until the result is ready. The polling
> > > timeout is specified in milliseconds in the datasheet and not in
> > > register access attempts.
> > >
> > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> >
> > Hi Steen
> >
> > Have you seen real issues with this code? You have marked this for
> > net, indicating it is a bug fix. If it is a real fix, please provide a
> > fixes: tag.
> >
> > Thanks
> > Andrew
>
> Hi Andrew,
>
> It is not a bug on the currently supported platform, but we observed
> that the code does not work properly on other platforms that we want to
> support as the timing requirements there are different. So maybe this
> is rather an improvement than a fix...
>
> Should this rather go to net-next?
The requirements for stable are listed here:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
net-next seems a better fit.
Andrew
prev parent reply other threads:[~2018-12-20 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 9:08 [PATCH net] mscc: Register poll timeout should be wall time not attempts Steen Hegelund
2018-12-20 10:29 ` Alexandre Belloni
2018-12-20 10:31 ` Andrew Lunn
2018-12-20 11:11 ` Steen Hegelund
2018-12-20 11:31 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220113111.GE13180@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).