From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Gunthorpe <jgg@mellanox.com>
Subject: Re: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as
 some general object
Date: Thu, 20 Dec 2018 17:02:12 +0000
Message-ID: <20181220170205.GD29267@mellanox.com>
References: <20181219142815.21480-1-leon@kernel.org>
 <20181219191406.GX30567@mellanox.com>
 <20181220062133.GH13943@mtr-leonro.mtl.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Doug Ledford <dledford@redhat.com>,
        Yishai Hadas <yishaih@mellanox.com>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        Achiad Shochat <achiad@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        linux-netdev <netdev@vger.kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr80083.outbound.protection.outlook.com ([40.107.8.83]:53370
        "EHLO EUR04-VI1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1728257AbeLTRC7 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 20 Dec 2018 12:02:59 -0500
In-Reply-To: <20181220062133.GH13943@mtr-leonro.mtl.com>
Content-Language: en-US
Content-ID: <935113F13177AB40B7781C77930CE977@eurprd05.prod.outlook.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Dec 20, 2018 at 08:21:33AM +0200, Leon Romanovsky wrote:
> On Wed, Dec 19, 2018 at 07:14:12PM +0000, Jason Gunthorpe wrote:
> > On Wed, Dec 19, 2018 at 04:28:15PM +0200, Leon Romanovsky wrote:
> > > From: Yishai Hadas <yishaih@mellanox.com>
> > >
> > > The driver needs to prevent a user space application to create a
> > > UMEM and UCTX via the general object command.
> > >
> > > The UMEM must go through the kernel UMEM_REG method to prevent the us=
er
> > > from setting physical addresses by himself.  The UCTX is some interna=
l
> > > kernel object and shouldn't be exposed.
> > >
> > > As of not being any more part of the general object the caps bits wer=
e
> > > moved to be some log_xxx indication in the general HCA caps, 0 means =
not
> > > supported.
> > >
> > > The firmware code was adapted as well to match the above.
> >
> > This commit message is a bit wonky.. how about
> >
> > IB/mlx5: Use the correct commands for UMEM and UCTX allocation
> >
> > During testing the command format was changed to close a security
> > hole. Revise the driver to use the command format that will actually
> > be supported in GA firmware.
> >
> > Both the UMEM and UCTX are intended only for use by the kernel and
> > cannot be executed using a general command.
> >
> > Since the UMEM and CTX are not part of the general object the caps
> > bits were moved to be some log_xxx location in the general HCA caps.
>=20
> I'm fine with this description too.
>=20
> >
> > > Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
> > > Reviewed-by: Achiad Shochat <achiad@mellanox.com>
> > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> >
> > Also add a fixes line please, any kernel with the devx needs this
> > patch to work with GA firmware.
>=20
> Fixes: a8b92ca1b0e5 ("IB/mlx5: Introduce DEVX")
>=20
> >
> > >  drivers/infiniband/hw/mlx5/devx.c | 34 ++++++++---------
> > >  drivers/infiniband/hw/mlx5/main.c |  3 +-
> > >  include/linux/mlx5/mlx5_ifc.h     | 62 +++++++++++++++++++++--------=