From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Vorel <pvorel@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] testsuite: Fix colorize
Date: Thu, 20 Dec 2018 20:17:48 -0800 [thread overview]
Message-ID: <20181220201748.0f0bd619@xeon-e3> (raw)
In-Reply-To: <20181218192904.18309-1-pvorel@suse.cz>
On Tue, 18 Dec 2018 20:29:04 +0100
Petr Vorel <pvorel@suse.cz> wrote:
> bash and dash require for escape sequence to use 'echo -e' or printf
> (but working on zsh). Choosing printf as it's implementation is IMHO
> more portable than echo implementations.
> dash also require to use \033[0; as escape sequence instead of \e[0;
>
> NOTE: \e[0; kept in lib/color.c as it's not problematic for C code
> (working when run ip on various shells).
>
> Fixes: 7e2f71b4 ("testsuite: colorize test result output")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Sure applied. Not sure why people expect tests to work without
bash. Next they will want it to work with clang on BSD...
next prev parent reply other threads:[~2018-12-21 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 19:29 [PATCH iproute2 1/1] testsuite: Fix colorize Petr Vorel
2018-12-21 4:17 ` Stephen Hemminger [this message]
2018-12-21 13:04 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220201748.0f0bd619@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).