From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 1/1] testsuite: Fix colorize
Date: Thu, 20 Dec 2018 20:17:48 -0800
Message-ID: <20181220201748.0f0bd619@xeon-e3>
References: <20181218192904.18309-1-pvorel@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Petr Vorel <pvorel@suse.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f195.google.com ([209.85.215.195]:37370 "EHLO
        mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732230AbeLUERv (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 20 Dec 2018 23:17:51 -0500
Received: by mail-pg1-f195.google.com with SMTP id c25so1890511pgb.4
        for <netdev@vger.kernel.org>; Thu, 20 Dec 2018 20:17:51 -0800 (PST)
In-Reply-To: <20181218192904.18309-1-pvorel@suse.cz>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 18 Dec 2018 20:29:04 +0100
Petr Vorel <pvorel@suse.cz> wrote:

> bash and dash require for escape sequence to use 'echo -e' or printf
> (but working on zsh). Choosing printf as it's implementation is IMHO
> more portable than echo implementations.
> dash also require to use \033[0; as escape sequence instead of \e[0;
> 
> NOTE: \e[0; kept in lib/color.c as it's not problematic for C code
> (working when run ip on various shells).
> 
> Fixes: 7e2f71b4 ("testsuite: colorize test result output")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Sure applied. Not sure why people expect tests to work without
bash. Next they will want it to work with clang on BSD...