From: Guillaume Nault <g.nault@alphalink.fr>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer
Date: Thu, 20 Dec 2018 22:42:15 +0100 [thread overview]
Message-ID: <20181220214103.gq67pakntf4bqkrr@kdev> (raw)
In-Reply-To: <20181220182920.4208-1-semen.protsenko@linaro.org>
On Thu, Dec 20, 2018 at 08:29:20PM +0200, Sam Protsenko wrote:
> Extract "Protocol" field decompression code from transport protocols to
> PPP generic layer, where it actually belongs. As a consequence, this
> patch fixes incorrect place of PFC decompression in L2TP driver (when
> it's not PPPOX_BOUND) and also enables this decompression for other
> protocols, like PPPoE.
>
Nice to see PFC implementation moving to ppp_generic.
> Protocol field decompression also happens in PPP Multilink Protocol
> code and in PPP compression protocols implementations (bsd, deflate,
> mppe). It looks like there is no easy way to get rid of that, so it was
> decided to leave it as is, but provide those cases with appropriate
> comments instead.
>
Thanks a lot for taking care of all these particular cases.
Reviewed-by: Guillaume Nault <g.nault@alphalink.fr>
Just a side note, this is for net-next. It's better to make that
explicit by using a subject prefix like [PATCH net-next].
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> Changes in v2:
> - Fix the order of checking skb data room and proto decompression
> - Remove "inline" keyword from ppp_decompress_proto()
> - Don't split line before function name
> - Prefix ppp_decompress_proto() function with "__"
> - Add ppp_decompress_proto() function with skb data room checks
> - Add description for introduced functions
> - Fix comments (as per review on mailing list)
>
Also, for networking patches, list of changes normally goes into the
commit message.
next prev parent reply other threads:[~2018-12-20 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 18:29 [PATCH v2] ppp: Move PFC decompression to PPP generic layer Sam Protsenko
2018-12-20 21:42 ` Guillaume Nault [this message]
2018-12-21 0:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220214103.gq67pakntf4bqkrr@kdev \
--to=g.nault@alphalink.fr \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).