From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer Date: Thu, 20 Dec 2018 22:42:15 +0100 Message-ID: <20181220214103.gq67pakntf4bqkrr@kdev> References: <20181220182920.4208-1-semen.protsenko@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Sam Protsenko Return-path: Content-Disposition: inline In-Reply-To: <20181220182920.4208-1-semen.protsenko@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Dec 20, 2018 at 08:29:20PM +0200, Sam Protsenko wrote: > Extract "Protocol" field decompression code from transport protocols to > PPP generic layer, where it actually belongs. As a consequence, this > patch fixes incorrect place of PFC decompression in L2TP driver (when > it's not PPPOX_BOUND) and also enables this decompression for other > protocols, like PPPoE. > Nice to see PFC implementation moving to ppp_generic. > Protocol field decompression also happens in PPP Multilink Protocol > code and in PPP compression protocols implementations (bsd, deflate, > mppe). It looks like there is no easy way to get rid of that, so it was > decided to leave it as is, but provide those cases with appropriate > comments instead. > Thanks a lot for taking care of all these particular cases. Reviewed-by: Guillaume Nault Just a side note, this is for net-next. It's better to make that explicit by using a subject prefix like [PATCH net-next]. > Signed-off-by: Sam Protsenko > --- > Changes in v2: > - Fix the order of checking skb data room and proto decompression > - Remove "inline" keyword from ppp_decompress_proto() > - Don't split line before function name > - Prefix ppp_decompress_proto() function with "__" > - Add ppp_decompress_proto() function with skb data room checks > - Add description for introduced functions > - Fix comments (as per review on mailing list) > Also, for networking patches, list of changes normally goes into the commit message.