From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver Date: Fri, 21 Dec 2018 12:29:58 +0300 Message-ID: <20181221092958.GA2240@kadam> References: <1545190897-22622-1-git-send-email-Tristram.Ha@microchip.com> <20181219100532.GA2066@nanopsycho> <20181219160857.GA13878@amd> <20181219161532.GA2224@nanopsycho> <20181219172220.GA14258@amd> <63e9dd4b-33c0-a08b-2db1-dea81bdb97ac@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: marex@denx.de, pavel@denx.de, jiri@resnulli.us, andrew@lunn.ch, sergio.paracuellos@gmail.com, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org To: Tristram.Ha@microchip.com Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:42754 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730198AbeLUJau (ORCPT ); Fri, 21 Dec 2018 04:30:50 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Dec 19, 2018 at 10:50:16PM +0000, Tristram.Ha@microchip.com wrote: > > So if I change the new code, should I go back to correct the old code? Other operating systems would worry about breaking code which is working fine, but re-writing ancient code is The Linux Way. regards, dan carpenter