From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sun, 23 Dec 2018 11:58:09 +0100 [thread overview]
Message-ID: <20181223105809.GG32178@lunn.ch> (raw)
In-Reply-To: <24a9c917-facd-31b5-1d52-a9bbe95763dc@denx.de>
> I can also use a simple conditional, since I don't expect the number of
> HWMON properties to grow, eg.
>
> if (type == hwmon_in && attr == hwmon_in_lcrit_alarm) {...}
> if (type == hwmon_temp && attr == hwmon_temp_crit_alarm) {...}
Yes, that is fine.
Please make sure you Cc: the HWMON maintainer on this patch.
Andrew
next prev parent reply other threads:[~2018-12-23 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 23:35 [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver Marek Vasut
2018-12-22 17:39 ` Heiner Kallweit
2018-12-23 9:16 ` Marek Vasut
2018-12-23 9:41 ` Heiner Kallweit
2018-12-23 9:59 ` Andrew Lunn
2018-12-23 10:21 ` Marek Vasut
2018-12-23 10:35 ` Andrew Lunn
2018-12-23 10:48 ` Marek Vasut
2019-01-03 2:09 ` Marek Vasut
2019-01-03 6:23 ` Heiner Kallweit
2019-01-04 2:19 ` Marek Vasut
2019-01-04 2:53 ` Marek Vasut
2019-01-04 2:57 ` Florian Fainelli
2019-01-04 5:40 ` Marek Vasut
2018-12-22 20:51 ` Heiner Kallweit
2018-12-23 9:13 ` Marek Vasut
2018-12-23 10:06 ` Andrew Lunn
2018-12-23 10:49 ` Marek Vasut
2018-12-23 10:58 ` Andrew Lunn [this message]
2018-12-23 11:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223105809.GG32178@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).