From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sun, 23 Dec 2018 11:58:09 +0100
Message-ID: <20181223105809.GG32178@lunn.ch>
References: <20181221233552.3741-1-marex@denx.de>
 <ce8555e0-ef9b-5e1c-9365-c6365474edbf@gmail.com>
 <20181223100630.GB31681@lunn.ch>
 <24a9c917-facd-31b5-1d52-a9bbe95763dc@denx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>
To: Marek Vasut <marex@denx.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:56136 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727811AbeLWK6K (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 23 Dec 2018 05:58:10 -0500
Content-Disposition: inline
In-Reply-To: <24a9c917-facd-31b5-1d52-a9bbe95763dc@denx.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> I can also use a simple conditional, since I don't expect the number of
> HWMON properties to grow, eg.
> 
> if (type == hwmon_in && attr == hwmon_in_lcrit_alarm) {...}
> if (type == hwmon_temp && attr == hwmon_temp_crit_alarm) {...}

Yes, that is fine.

Please make sure you Cc: the HWMON maintainer on this patch.

       Andrew