From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent) Date: Sun, 23 Dec 2018 16:53:12 +0000 Message-ID: <20181223165312.GE2217@ZenIV.linux.org.uk> References: <20181219182031.8675-1-swarren@wwwdotorg.org> <20181220174318.GA21404@ziepe.ca> <20181220174448.GA21149@lst.de> <1545328145.185366.500.camel@acm.org> <072c2d9d187daf0672bf54ab035e47a05fd1cd1d.camel@perches.com> <20181221033159.GF23877@ziepe.ca> <20181221235230.GC13168@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jason Gunthorpe , Joe Perches , Bart Van Assche , Stephen Warren , Tariq Toukan , xavier.huwei@huawei.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Doug Ledford , Stephen Warren , Christoph Hellwig , Andrew Morton , Linus Torvalds , Jonathan Corbet , linux-kernel@vger.kernel.org To: Gal Pressman Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:44420 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbeLWQxk (ORCPT ); Sun, 23 Dec 2018 11:53:40 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Dec 23, 2018 at 06:42:20PM +0200, Gal Pressman wrote: > > -17) Don't re-invent the kernel macros > > +17) Using bool > > +-------------- > > + > > +The Linux kernel uses the C11 standard for the bool type. bool values can only C99, surely?