From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent) Date: Mon, 24 Dec 2018 15:08:10 -0700 Message-ID: <20181224220810.GA17036@ziepe.ca> References: <20181219182031.8675-1-swarren@wwwdotorg.org> <20181220174318.GA21404@ziepe.ca> <20181220174448.GA21149@lst.de> <1545328145.185366.500.camel@acm.org> <072c2d9d187daf0672bf54ab035e47a05fd1cd1d.camel@perches.com> <20181221033159.GF23877@ziepe.ca> <20181221235230.GC13168@ziepe.ca> <20181223165312.GE2217@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gal Pressman , Joe Perches , Bart Van Assche , Stephen Warren , Tariq Toukan , xavier.huwei@huawei.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Doug Ledford , Stephen Warren , Christoph Hellwig , Andrew Morton , Linus Torvalds , Jonathan Corbet , linux-kernel@vger.kernel.org To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20181223165312.GE2217@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Dec 23, 2018 at 04:53:12PM +0000, Al Viro wrote: > On Sun, Dec 23, 2018 at 06:42:20PM +0200, Gal Pressman wrote: > > > -17) Don't re-invent the kernel macros > > > +17) Using bool > > > +-------------- > > > + > > > +The Linux kernel uses the C11 standard for the bool type. bool values can only > > C99, surely? Oops, yes, that is right Jason