From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net V2 4/4] vhost: log dirty page correctly Date: Tue, 25 Dec 2018 11:25:32 -0500 Message-ID: <20181225111716-mutt-send-email-mst@kernel.org> References: <20181212100819.21295-1-jasowang@redhat.com> <20181212100819.21295-5-jasowang@redhat.com> <20181212092435-mutt-send-email-mst@kernel.org> <0239c220-e7ca-c08f-be26-eb9be63fced3@redhat.com> <20181213092930-mutt-send-email-mst@kernel.org> <519ee6f7-06fc-ad49-03da-c096aeb24ced@redhat.com> <20181214081821-mutt-send-email-mst@kernel.org> <55b3d55a-950f-eeaf-1908-bed78a1a9200@redhat.com> <20181224123654-mutt-send-email-mst@kernel.org> <9e57732f-2d42-173f-9297-42821f34ab8f@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Jintack Lim , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Jason Wang Return-path: Content-Disposition: inline In-Reply-To: <9e57732f-2d42-173f-9297-42821f34ab8f@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org T24gVHVlLCBEZWMgMjUsIDIwMTggYXQgMDU6NDM6MjVQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzI1IOS4iuWNiDE6NDEsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIE1vbiwgRGVjIDI0LCAyMDE4IGF0IDExOjQzOjMxQU0gKzA4MDAsIEphc29uIFdh bmcgd3JvdGU6Cj4gPiA+IE9uIDIwMTgvMTIvMTQg5LiL5Y2IOToyMCwgTWljaGFlbCBTLiBUc2ly a2luIHdyb3RlOgo+ID4gPiA+IE9uIEZyaSwgRGVjIDE0LCAyMDE4IGF0IDEwOjQzOjAzQU0gKzA4 MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiBPbiAyMDE4LzEyLzEzIOS4i+WNiDEwOjMx LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gSnVzdCB0byBtYWtlIHN1 cmUgSSB1bmRlcnN0YW5kIHRoaXMuIEl0IGxvb2tzIHRvIG1lIHdlIHNob3VsZDoKPiA+ID4gPiA+ ID4gPiAKPiA+ID4gPiA+ID4gPiAtIGFsbG93IHBhc3NpbmcgR0lPVkEtPkdQQSB0aHJvdWdoIFVB UEkKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAtIGNhY2hlIEdJT1ZBLT5HUEEgc29tZXdo ZXJlIGJ1dCBzdGlsbCB1c2UgR0lPVkEtPkhWQSBpbiBkZXZpY2UgSU9UTEIgZm9yCj4gPiA+ID4g PiA+ID4gcGVyZm9ybWFuY2UKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBJcyB0aGlzIHdo YXQgeW91IHN1Z2dlc3Q/Cj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gVGhhbmtzCj4gPiA+ ID4gPiA+IE5vdCByZWFsbHkuIFdlIGFscmVhZHkgaGF2ZSBHUEEtPkhWQSwgc28gSSBzdWdnZXN0 ZWQgYSBmbGFnIHRvIHBhc3MKPiA+ID4gPiA+ID4gR0lPVkEtPkdQQSBpbiB0aGUgSU9UTEIuCj4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBUaGlzIGhhcyBhZHZhbnRhZ2VzIGZvciBzZWN1cml0eSBz aW5jZSBhIHNpbmdsZSB0YWJsZSBuZWVkcwo+ID4gPiA+ID4gPiB0aGVuIHRvIGJlIHZhbGlkYXRl ZCB0byBlbnN1cmUgZ3Vlc3QgZG9lcyBub3QgY29ycnVwdAo+ID4gPiA+ID4gPiBRRU1VIG1lbW9y eS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiBJIHdvbmRlciBob3cgbXVjaCB3ZSBjYW4gZ2FpbiB0 aHJvdWdoIHRoaXMuIEN1cnJlbnRseSwgcWVtdSBJT01NVSBnaXZlcwo+ID4gPiA+ID4gR0lPVkEt PkdQQSBtYXBwaW5nLCBhbmQgcWVtdSB2aG9zdCBjb2RlIHdpbGwgdHJhbnNsYXRlIEdQQSB0byBI VkEgdGhlbiBwYXNzCj4gPiA+ID4gPiBHSU9WQS0+SFZBIHRvIHZob3N0LiBJdCBsb29rcyBubyBk aWZmZXJlbmNlIHRvIG1lLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGFua3MKPiA+ID4gPiBUaGUg ZGlmZmVyZW5jZSBpcyBpbiBzZWN1cml0eSBub3QgaW4gcGVyZm9ybWFuY2UuICBHZXR0aW5nIGEg YmFkIEhWQQo+ID4gPiA+IGNvcnJ1cHRzIFFFTVUgbWVtb3J5IGFuZCBpdCBtaWdodCBiZSBndWVz dCBjb250cm9sbGVkLiBWZXJ5IHJpc2t5Lgo+ID4gPiBIb3cgY2FuIHRoaXMgYmUgY29udHJvbGxl ZCBieSBndWVzdD8gSFZBIHdhcyBnZW5lcmF0ZWQgZnJvbSBxZW11IHJhbSBibG9ja3MKPiA+ID4g d2hpY2ggaXMgdG90YWxseSB1bmRlciB0aGUgY29udHJvbCBvZiBxZW11IG1lbW9yeSBjb3JlIGlu c3RlYWQgb2YgZ3Vlc3QuCj4gPiA+IAo+ID4gPiAKPiA+ID4gVGhhbmtzCj4gPiBJdCBpcyB1bHRp bWF0ZWx5IHVuZGVyIGd1ZXN0IGluZmx1ZW5jZSBhcyBndWVzdCBzdXBwbGllcyBJT1ZBLT5HUEEK PiA+IHRyYW5zbGF0aW9ucy4gIHFlbXUgdHJhbnNsYXRlcyBHUEEtPkhWQSBhbmQgZ2l2ZXMgdGhl IHRyYW5zbGF0ZWQgcmVzdWx0Cj4gPiB0byB0aGUga2VybmVsLiAgSWYgaXQncyBub3QgYnVnZ3kg YW5kIGtlcm5lbCBpc24ndCBidWdneSBpdCdzIGFsbAo+ID4gZmluZS4KPiAKPiAKPiBJZiBxZW11 IHByb3ZpZGVzIGJ1Z2d5IEdQQS0+SFZBLCB3ZSBjYW4ndCB3b3JrYXJvdW5kIHRoaXMuIEFuZCBJ IGRvbid0IGdldAo+IHRoZSBwb2ludCB3aHkgd2UgZXZlbiB3YW50IHRvIHRyeSB0aGlzLiBCdWdn eSBxZW11IGNvZGUgY2FuIGNyYXNoIGl0c2VsZiBpbgo+IG1hbnkgd2F5cy4KPiAKPiAKPiA+IAo+ ID4gQnV0IHRoYXQncyB0aGUgYXBwcm9hY2ggdGhhdCB3YXMgcHJvdmVuIG5vdCB0byB3b3JrIGlu IHRoZSAyMHRoIGNlbnR1cnkuCj4gPiBJbiB0aGUgMjFzdCBjZW50dXJ5IHdlIGFyZSB0cnlpbmcg ZGVmZW5jZSBpbiBkZXB0aCBhcHByb2FjaC4KPiA+IAo+ID4gTXkgcG9pbnQgaXMgdGhhdCBhIHNp bmdsZSBjb2RlIHBhdGggdGhhdCBpcyByZXNwb25zaWJsZSBmb3IKPiA+IHRoZSBIVkEgdHJhbnNs YXRpb25zIGlzIGJldHRlciB0aGFuIHR3by4KPiA+IAo+IAo+IFNvIHRoZSBkaWZmZXJlbmNlIHdo ZXRoZXIgb3Igbm90IHVzZSBtZW1vcnkgdGFibGUgaW5mb3JtYXRpb246Cj4gCj4gQ3VycmVudDoK PiAKPiAxKSBTRVRfTUVNX1RBQkxFOiBHUEEtPkhWQQo+IAo+IDIpIFFlbXUgR0lPVkEtPkdQQQo+ IAo+IDMpIFFlbXUgR1BBLT5IVkEKPiAKPiA0KSBJT1RMQl9VUERBVEU6IEdJT1ZBLT5IVkEKPiAK PiBJZiBJIHVuZGVyc3RhbmQgY29ycmVjdGx5IHlvdSB3YW50IHRvIGRyb3Agc3RlcCAzIGNvbnNp ZGVyIGl0IG1pZ2h0IGJlIGJ1Z2d5Cj4gd2hpY2ggaXMganVzdCAxOSBsaW5lcyBvZiBjb2RlIGlu IHFlbXUgKHZob3N0X21lbW9yeV9yZWdpb25fbG9va3VwKCkpLiBUaGlzCj4gd2lsbCBlbmRzIHVw Ogo+IAo+IDEpIERvIEdQQS0+SFZBIHRyYW5zbGF0aW9uIGluIElPVExCX1VQREFURSBwYXRoIChJ IGJlbGlldmUgd2Ugd29uJ3Qgd2FudCB0bwo+IGRvIGl0IGR1cmluZyBkZXZpY2UgSU9UTEIgbG9v a3VwKS4KPiAKPiAyKSBFeHRyYSBiaXRzIHRvIGVuYWJsZSB0aGlzIGNhcGFiaWxpdHkuCj4gCj4g U28gdGhpcyBsb29rcyBuZWVkIG1vcmUgY29kZXMgaW4ga2VybmVsIHRoYW4gd2hhdCBxZW11IGRp ZCBpbiB1c2Vyc3BhY2UuwqAgSXMKPiB0aGlzIHJlYWxseSB3b3J0aHdoaWxlPwo+IAo+IFRoYW5r cwoKU28gdGhlcmUgYXJlIHNldmVyYWwgcG9pbnRzIEkgd291bGQgbGlrZSB0byBtYWtlCgoxLiBB dCB0aGUgbW9tZW50IHdpdGhvdXQgYW4gaW9tbXUgaXQgaXMgcG9zc2libGUgdG8KICAgY2hhbmdl IEdQQS1IVkEgbWFwcGluZ3MgYW5kIGV2ZXJ5dGhpbmcga2VlcHMgd29ya2luZwogICBiZWNhdXNl IGEgY2hhbmdlIGluIG1lbW9yeSB0YWJsZXMgZmx1c2hlcyB0aGUgcmluZ3MuCiAgIEhvd2V2ZXIg SSBkb24ndCBzZWUgdGhlIGlvdGxiIGNhY2hlIGJlaW5nIGludmFsaWRhdGVkCiAgIG9uIHRoYXQg cGF0aCAtIGRpZCBJIG1pc3MgaXQ/IElmIGl0IGlzIG5vdCB0aGVyZSBpdCdzCiAgIGEgcmVsYXRl ZCBtaW5vciBidWcuCgoyLiBxZW11IGFscmVhZHkgaGFzIGEgR1BBLiBEaXNjYXJkaW5nIGl0IGFu ZCByZS1jYWxjdWxhdGluZwogICB3aGVuIGxvZ2dpbmcgaXMgb24ganVzdCBzZWVtcyB3cm9uZy4K ICAgSG93ZXZlciBpZiB5b3Ugd291bGQgbGlrZSB0byAqYWxzbyoga2VlcCB0aGUgSFZBIGluIHRo ZSBpb3RsYgogICB0byBhdm9pZCBkb2luZyBleHRyYSB0cmFuc2xhdGlvbnMsIHRoYXQgc291bmRz IGxpa2UgYQogICByZWFzb25hYmxlIG9wdGltaXphdGlvbi4KCjMuIGl0IGFsc28gbWVhbnMgdGhh dCB0aGUgaHZhLT5ncGEgdHJhbnNsYXRpb24gb25seSBydW5zCiAgIHdoZW4gbG9nZ2luZyBpcyBl bmFibGVkLiBUaGF0IGlzIGEgcmFyZWx5IGV4Y2VyY2lzZWQKICAgcGF0aCBzbyBhbnkgYnVncyB0 aGVyZSB3aWxsIG5vdCBiZSBjYXVnaHQuCgpTbyBJIHJlYWxseSB3b3VsZCBsaWtlIHVzIGxvbmcg dGVybSB0byBtb3ZlIGF3YXkgZnJvbQpodmEtPmdwYSB0cmFuc2xhdGlvbnMsIGtlZXAgdGhlbSBm b3IgbGVnYWN5IHVzZXJzcGFjZSBvbmx5CmJ1dCBJIGRvbid0IHJlYWxseSBtaW5kIGhvdyB3ZSBk byBpdC4KCkhvdyBhYm91dAotIGEgbmV3IGZsYWcgdG8gcGFzcyBhbiBpb3RsYiB3aXRoICpib3Ro KiBhIGdwYSBhbmQgaHZhCi0gZm9yIGxlZ2FjeSB1c2Vyc3BhY2UsIGNhbGN1bGF0ZSB0aGUgZ3Bh IG9uIGlvdGxiIHVwZGF0ZQogIHNvIHRoZSBkZXZpY2UgdGhlbiB1c2VzIGEgc2hhcmVkIGNvZGUg cGF0aAoKd2hhdCBkbyB5b3UgdGhpbms/CgoKLS0gCk1TVApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51 eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=