From: Ido Schimmel <idosch@idosch.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com,
Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>,
Jan Jablonsky <jan.jablonsky@thalesgroup.com>
Subject: Re: [net-next 01/10] igb: reduce CPU0 latency when updating statistics
Date: Tue, 25 Dec 2018 17:47:15 +0200 [thread overview]
Message-ID: <20181225154715.GA20609@splinter.mtl.com> (raw)
In-Reply-To: <20181220205634.8509-2-jeffrey.t.kirsher@intel.com>
On Thu, Dec 20, 2018 at 12:56:25PM -0800, Jeff Kirsher wrote:
> This change is based off of the work and suggestion of Jan Jablonsky
> <jan.jablonsky@thalesgroup.com>.
>
> The Watchdog workqueue in igb driver is scheduled every 2s for each
> network interface. That includes updating a statistics protected by
> spinlock. Function igb_update_stats in this case will be protected
> against preemption. According to number of a statistics registers
> (cca 60), processing this function might cause additional cpu load
> on CPU0.
>
> In case of statistics spinlock may be replaced with mutex, which
> reduce latency on CPU0.
>
> CC: Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>
> CC: Jan Jablonsky <jan.jablonsky@thalesgroup.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Hi,
I'm hitting following issue with this commit:
https://lists.01.org/pipermail/lkp/2018-September/009139.html
next prev parent reply other threads:[~2018-12-25 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 20:56 [net-next 00/10][pull request] Intel Wired LAN Driver Updates 2018-12-20 Jeff Kirsher
2018-12-20 20:56 ` [net-next 01/10] igb: reduce CPU0 latency when updating statistics Jeff Kirsher
2018-12-25 15:47 ` Ido Schimmel [this message]
2019-01-07 10:22 ` Yanko Kaneti
2019-01-22 16:12 ` JABLONSKY Jan
2018-12-20 20:56 ` [net-next 02/10] igb: Change RXPBSIZE size when setting Qav mode Jeff Kirsher
2018-12-20 20:56 ` [net-next 03/10] Documentation: igb: Add a section about CBS Jeff Kirsher
2018-12-20 20:56 ` [net-next 04/10] e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait Jeff Kirsher
2018-12-20 20:56 ` [net-next 05/10] i40e: define proper net_device::neigh_priv_len Jeff Kirsher
2018-12-20 20:56 ` [net-next 06/10] i40e: extend PTP gettime function to read system clock Jeff Kirsher
2018-12-20 20:56 ` [net-next 07/10] ice: Do not enable NAPI on q_vectors that have no rings Jeff Kirsher
2018-12-20 20:56 ` [net-next 08/10] igb: Fix an issue that PME is not enabled during runtime suspend Jeff Kirsher
2018-12-20 20:56 ` [net-next 09/10] ixgbe: register a mdiobus Jeff Kirsher
2018-12-20 20:56 ` [net-next 10/10] ixgbe: use mii_bus to handle MII related ioctls Jeff Kirsher
2018-12-20 23:45 ` [net-next 00/10][pull request] Intel Wired LAN Driver Updates 2018-12-20 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181225154715.GA20609@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=bernhard.kaindl@thalesgroup.com \
--cc=davem@davemloft.net \
--cc=jan.jablonsky@thalesgroup.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).