From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH RFC 1/2] virtio-net: bql support
Date: Wed, 26 Dec 2018 10:15:05 -0500
Message-ID: <20181226101411-mutt-send-email-mst@kernel.org>
References: <20181205225323.12555-1-mst@redhat.com>
	<20181205225323.12555-2-mst@redhat.com>
	<21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	maxime.coquelin@redhat.com, wexu@redhat.com,
	"David S. Miller" <davem@davemloft.net>
To: Jason Wang <jasowang@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

T24gVGh1LCBEZWMgMDYsIDIwMTggYXQgMDQ6MTc6MzZQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90
ZToKPiAKPiBPbiAyMDE4LzEyLzYg5LiK5Y2INjo1NCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl
Ogo+ID4gV2hlbiB1c2VfbmFwaSBpcyBzZXQsIGxldCdzIGVuYWJsZSBCUUxzLiAgTm90ZTogc29t
ZSBvZiB0aGUgaXNzdWVzIGFyZQo+ID4gc2ltaWxhciB0byB3aWZpLiAgSXQncyB3b3J0aCBjb25z
aWRlcmluZyB3aGV0aGVyIHNvbWV0aGluZyBzaW1pbGFyIHRvCj4gPiBjb21taXQgMzYxNDhjMmJi
ZmJlICgibWFjODAyMTE6IEFkanVzdCBUU1EgcGFjaW5nIHNoaWZ0IikgbWlnaHQgYmUKPiA+IGJl
bmVmaXRpYWwuCj4gCj4gCj4gSSd2ZSBwbGF5ZWQgYSBzaW1pbGFyIHBhdGNoIHNldmVyYWwgZGF5
cyBiZWZvcmUuIFRoZSB0cmlja3kgcGFydCBpcyB0aGUgbW9kZQo+IHN3aXRjaGluZyBiZXR3ZWVu
IG5hcGkgYW5kIG5vIG5hcGkuIFdlIHNob3VsZCBtYWtlIHN1cmUgd2hlbiB0aGUgcGFja2V0IGlz
Cj4gc2VudCBhbmQgdHJha2NlZCBieSBCUUwswqAgaXQgc2hvdWxkIGJlIGNvbnN1bWVkIGJ5IEJR
TCBhcyB3ZWxsLiBJIGRpZCBpdCBieQo+IHRyYWNraW5nIGl0IHRocm91Z2ggc2tiLT5jYi7CoCBB
bmQgZGVhbCB3aXRoIHRoZSBmcmVlemUgYnkgcmVzZXQgdGhlIEJRTAo+IHN0YXR1cy4gUGF0Y2gg
YXR0YWNoZWQuCj4gCj4gQnV0IHdoZW4gdGVzdGluZyB3aXRoIHZob3N0LW5ldCwgSSBkb24ndCB2
ZXJ5IGEgc3RhYmxlIHBlcmZvcm1hbmNlLCBpdCB3YXMKPiBwcm9iYWJseSBiZWNhdXNlIHdlIGJh
dGNoIHRoZSB1c2VkIHJpbmcgdXBkYXRpbmcgc28gdHggaW50ZXJydXB0IG1heSBjb21lCj4gcmFu
ZG9tbHkuIFdlIHByb2JhYmx5IG5lZWQgdG8gaW1wbGVtZW50IHRpbWUgYm91bmRlZCBjb2FsZXNj
aW5nIG1lY2hhbmlzbQo+IHdoaWNoIGNvdWxkIGJlIGNvbmZpZ3VyZWQgZnJvbSB1c2Vyc3BhY2Uu
Cj4gCj4gQnR3LCBtYXliZSBpdCdzIHRpbWUganVzdCBlbmFibGUgbmFwaSBUWCBieSBkZWZhdWx0
LiBJIGdldCB+MTAlIFRDUF9SUgo+IHJlZ3Jlc3Npb24gb24gbWFjaGluZSB3aXRob3V0IEFQSUN2
LCAoaGF2ZW4ndCBmb3VuZCB0aW1lIHRvIHRlc3QgQVBJQ3YKPiBtYWNoaW5lKS4gQnV0IGNvbnNp
ZGVyIGl0IHdhcyBmb3IgY29ycmVjdG5lc3MsIEkgdGhpbmsgaXQncyBhY2NlcHRhYmxlPyBUaGVu
Cj4gd2UgY2FuIGRvIG9wdGltaXphdGlvbiBvbiB0b3A/Cj4gCj4gCj4gVGhhbmtzCgpJIGRvbid0
IHNlZSBob3cgaXQncyBmb3IgY29ycmVjdG5lc3MgdG8gYmUgZnJhbmsuCldoYXQgaWYgd2UganVz
dCBkbyB0aGUgYnVsayBmcmVlPyBEb2VzIHRoYXQgZml4IHRoZSByZWdyZXNzaW9uPwoKCj4gCj4g
PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgo+ID4g
LS0tCj4gPiAgIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDI3ICsrKysrKysrKysrKysrKysr
KystLS0tLS0tLQo+ID4gICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgOCBkZWxl
dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBi
L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gaW5kZXggY2VjZmQ3N2M5ZjNjLi5iNjU3YmRl
NmI5NGIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiA+ICsrKyBi
L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gQEAgLTEzMjUsNyArMTMyNSw4IEBAIHN0YXRp
YyBpbnQgdmlydG5ldF9yZWNlaXZlKHN0cnVjdCByZWNlaXZlX3F1ZXVlICpycSwgaW50IGJ1ZGdl
dCwKPiA+ICAgCXJldHVybiBzdGF0cy5wYWNrZXRzOwo+ID4gICB9Cj4gPiAtc3RhdGljIHZvaWQg
ZnJlZV9vbGRfeG1pdF9za2JzKHN0cnVjdCBzZW5kX3F1ZXVlICpzcSkKPiA+ICtzdGF0aWMgdm9p
ZCBmcmVlX29sZF94bWl0X3NrYnMoc3RydWN0IHNlbmRfcXVldWUgKnNxLCBzdHJ1Y3QgbmV0ZGV2
X3F1ZXVlICp0eHEsCj4gPiArCQkJICAgICAgIGJvb2wgdXNlX25hcGkpCj4gPiAgIHsKPiA+ICAg
CXN0cnVjdCBza19idWZmICpza2I7Cj4gPiAgIAl1bnNpZ25lZCBpbnQgbGVuOwo+ID4gQEAgLTEz
NDcsNiArMTM0OCw5IEBAIHN0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ticyhzdHJ1Y3Qgc2Vu
ZF9xdWV1ZSAqc3EpCj4gPiAgIAlpZiAoIXBhY2tldHMpCj4gPiAgIAkJcmV0dXJuOwo+ID4gKwlp
ZiAodXNlX25hcGkpCj4gPiArCQluZXRkZXZfdHhfY29tcGxldGVkX3F1ZXVlKHR4cSwgcGFja2V0
cywgYnl0ZXMpOwo+ID4gKwo+ID4gICAJdTY0X3N0YXRzX3VwZGF0ZV9iZWdpbigmc3EtPnN0YXRz
LnN5bmNwKTsKPiA+ICAgCXNxLT5zdGF0cy5ieXRlcyArPSBieXRlczsKPiA+ICAgCXNxLT5zdGF0
cy5wYWNrZXRzICs9IHBhY2tldHM7Cj4gPiBAQCAtMTM2NCw3ICsxMzY4LDcgQEAgc3RhdGljIHZv
aWQgdmlydG5ldF9wb2xsX2NsZWFudHgoc3RydWN0IHJlY2VpdmVfcXVldWUgKnJxKQo+ID4gICAJ
CXJldHVybjsKPiA+ICAgCWlmIChfX25ldGlmX3R4X3RyeWxvY2sodHhxKSkgewo+ID4gLQkJZnJl
ZV9vbGRfeG1pdF9za2JzKHNxKTsKPiA+ICsJCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCB0
cnVlKTsKPiA+ICAgCQlfX25ldGlmX3R4X3VubG9jayh0eHEpOwo+ID4gICAJfQo+ID4gQEAgLTE0
NDAsNyArMTQ0NCw3IEBAIHN0YXRpYyBpbnQgdmlydG5ldF9wb2xsX3R4KHN0cnVjdCBuYXBpX3N0
cnVjdCAqbmFwaSwgaW50IGJ1ZGdldCkKPiA+ICAgCXN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSA9
IG5ldGRldl9nZXRfdHhfcXVldWUodmktPmRldiwgdnEydHhxKHNxLT52cSkpOwo+ID4gICAJX19u
ZXRpZl90eF9sb2NrKHR4cSwgcmF3X3NtcF9wcm9jZXNzb3JfaWQoKSk7Cj4gPiAtCWZyZWVfb2xk
X3htaXRfc2ticyhzcSk7Cj4gPiArCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCB0cnVlKTsK
PiA+ICAgCV9fbmV0aWZfdHhfdW5sb2NrKHR4cSk7Cj4gPiAgIAl2aXJ0cXVldWVfbmFwaV9jb21w
bGV0ZShuYXBpLCBzcS0+dnEsIDApOwo+ID4gQEAgLTE1MDUsMTMgKzE1MDksMTUgQEAgc3RhdGlj
IG5ldGRldl90eF90IHN0YXJ0X3htaXQoc3RydWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG5ldF9k
ZXZpY2UgKmRldikKPiA+ICAgCXN0cnVjdCBzZW5kX3F1ZXVlICpzcSA9ICZ2aS0+c3FbcW51bV07
Cj4gPiAgIAlpbnQgZXJyOwo+ID4gICAJc3RydWN0IG5ldGRldl9xdWV1ZSAqdHhxID0gbmV0ZGV2
X2dldF90eF9xdWV1ZShkZXYsIHFudW0pOwo+ID4gLQlib29sIGtpY2sgPSAhc2tiLT54bWl0X21v
cmU7Cj4gPiArCWJvb2wgbW9yZSA9IHNrYi0+eG1pdF9tb3JlOwo+ID4gICAJYm9vbCB1c2VfbmFw
aSA9IHNxLT5uYXBpLndlaWdodDsKPiA+ICsJdW5zaWduZWQgaW50IGJ5dGVzID0gc2tiLT5sZW47
Cj4gPiArCWJvb2wga2ljazsKPiA+ICAgCS8qIEZyZWUgdXAgYW55IHBlbmRpbmcgb2xkIGJ1ZmZl
cnMgYmVmb3JlIHF1ZXVlaW5nIG5ldyBvbmVzLiAqLwo+ID4gLQlmcmVlX29sZF94bWl0X3NrYnMo
c3EpOwo+ID4gKwlmcmVlX29sZF94bWl0X3NrYnMoc3EsIHR4cSwgdXNlX25hcGkpOwo+ID4gLQlp
ZiAodXNlX25hcGkgJiYga2ljaykKPiA+ICsJaWYgKHVzZV9uYXBpICYmICFtb3JlKQo+ID4gICAJ
CXZpcnRxdWV1ZV9lbmFibGVfY2JfZGVsYXllZChzcS0+dnEpOwo+ID4gICAJLyogdGltZXN0YW1w
IHBhY2tldCBpbiBzb2Z0d2FyZSAqLwo+ID4gQEAgLTE1NTIsNyArMTU1OCw3IEBAIHN0YXRpYyBu
ZXRkZXZfdHhfdCBzdGFydF94bWl0KHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBuZXRfZGV2
aWNlICpkZXYpCj4gPiAgIAkJaWYgKCF1c2VfbmFwaSAmJgo+ID4gICAJCSAgICB1bmxpa2VseSgh
dmlydHF1ZXVlX2VuYWJsZV9jYl9kZWxheWVkKHNxLT52cSkpKSB7Cj4gPiAgIAkJCS8qIE1vcmUg
anVzdCBnb3QgdXNlZCwgZnJlZSB0aGVtIHRoZW4gcmVjaGVjay4gKi8KPiA+IC0JCQlmcmVlX29s
ZF94bWl0X3NrYnMoc3EpOwo+ID4gKwkJCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCBmYWxz
ZSk7Cj4gPiAgIAkJCWlmIChzcS0+dnEtPm51bV9mcmVlID49IDIrTUFYX1NLQl9GUkFHUykgewo+
ID4gICAJCQkJbmV0aWZfc3RhcnRfc3VicXVldWUoZGV2LCBxbnVtKTsKPiA+ICAgCQkJCXZpcnRx
dWV1ZV9kaXNhYmxlX2NiKHNxLT52cSk7Cj4gPiBAQCAtMTU2MCw3ICsxNTY2LDEyIEBAIHN0YXRp
YyBuZXRkZXZfdHhfdCBzdGFydF94bWl0KHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBuZXRf
ZGV2aWNlICpkZXYpCj4gPiAgIAkJfQo+ID4gICAJfQo+ID4gLQlpZiAoa2ljayB8fCBuZXRpZl94
bWl0X3N0b3BwZWQodHhxKSkgewo+ID4gKwlpZiAodXNlX25hcGkpCj4gPiArCQlraWNrID0gX19u
ZXRkZXZfdHhfc2VudF9xdWV1ZSh0eHEsIGJ5dGVzLCBtb3JlKTsKPiA+ICsJZWxzZQo+ID4gKwkJ
a2ljayA9ICFtb3JlIHx8IG5ldGlmX3htaXRfc3RvcHBlZCh0eHEpOwo+ID4gKwo+ID4gKwlpZiAo
a2ljaykgewo+ID4gICAJCWlmICh2aXJ0cXVldWVfa2lja19wcmVwYXJlKHNxLT52cSkgJiYgdmly
dHF1ZXVlX25vdGlmeShzcS0+dnEpKSB7Cj4gPiAgIAkJCXU2NF9zdGF0c191cGRhdGVfYmVnaW4o
JnNxLT5zdGF0cy5zeW5jcCk7Cj4gPiAgIAkJCXNxLT5zdGF0cy5raWNrcysrOwpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWls
aW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6
Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRp
b24=