From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH RFC 1/2] virtio-net: bql support
Date: Wed, 26 Dec 2018 10:19:39 -0500
Message-ID: <20181226101528-mutt-send-email-mst@kernel.org>
References: <20181205225323.12555-1-mst@redhat.com>
	<20181205225323.12555-2-mst@redhat.com>
	<21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	maxime.coquelin@redhat.com, wexu@redhat.com,
	"David S. Miller" <davem@davemloft.net>
To: Jason Wang <jasowang@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

T24gVGh1LCBEZWMgMDYsIDIwMTggYXQgMDQ6MTc6MzZQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90
ZToKPiAKPiBPbiAyMDE4LzEyLzYg5LiK5Y2INjo1NCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl
Ogo+ID4gV2hlbiB1c2VfbmFwaSBpcyBzZXQsIGxldCdzIGVuYWJsZSBCUUxzLiAgTm90ZTogc29t
ZSBvZiB0aGUgaXNzdWVzIGFyZQo+ID4gc2ltaWxhciB0byB3aWZpLiAgSXQncyB3b3J0aCBjb25z
aWRlcmluZyB3aGV0aGVyIHNvbWV0aGluZyBzaW1pbGFyIHRvCj4gPiBjb21taXQgMzYxNDhjMmJi
ZmJlICgibWFjODAyMTE6IEFkanVzdCBUU1EgcGFjaW5nIHNoaWZ0IikgbWlnaHQgYmUKPiA+IGJl
bmVmaXRpYWwuCj4gCj4gCj4gSSd2ZSBwbGF5ZWQgYSBzaW1pbGFyIHBhdGNoIHNldmVyYWwgZGF5
cyBiZWZvcmUuIFRoZSB0cmlja3kgcGFydCBpcyB0aGUgbW9kZQo+IHN3aXRjaGluZyBiZXR3ZWVu
IG5hcGkgYW5kIG5vIG5hcGkuIFdlIHNob3VsZCBtYWtlIHN1cmUgd2hlbiB0aGUgcGFja2V0IGlz
Cj4gc2VudCBhbmQgdHJha2NlZCBieSBCUUwswqAgaXQgc2hvdWxkIGJlIGNvbnN1bWVkIGJ5IEJR
TCBhcyB3ZWxsLiBJIGRpZCBpdCBieQo+IHRyYWNraW5nIGl0IHRocm91Z2ggc2tiLT5jYi7CoCBB
bmQgZGVhbCB3aXRoIHRoZSBmcmVlemUgYnkgcmVzZXQgdGhlIEJRTAo+IHN0YXR1cy4gUGF0Y2gg
YXR0YWNoZWQuCj4gCj4gQnV0IHdoZW4gdGVzdGluZyB3aXRoIHZob3N0LW5ldCwgSSBkb24ndCB2
ZXJ5IGEgc3RhYmxlIHBlcmZvcm1hbmNlLAoKU28gaG93IGFib3V0IGluY3JlYXNpbmcgVFNRIHBh
Y2luZyBzaGlmdCB0aGVuPwoKPiBpdCB3YXMKPiBwcm9iYWJseSBiZWNhdXNlIHdlIGJhdGNoIHRo
ZSB1c2VkIHJpbmcgdXBkYXRpbmcgc28gdHggaW50ZXJydXB0IG1heSBjb21lCj4gcmFuZG9tbHku
IFdlIHByb2JhYmx5IG5lZWQgdG8gaW1wbGVtZW50IHRpbWUgYm91bmRlZCBjb2FsZXNjaW5nIG1l
Y2hhbmlzbQo+IHdoaWNoIGNvdWxkIGJlIGNvbmZpZ3VyZWQgZnJvbSB1c2Vyc3BhY2UuCgpJIGRv
bid0IHRoaW5rIGl0J3MgcmVhc29uYWJsZSB0byBleHBlY3QgdXNlcnNwYWNlIHRvIGJlIHRoYXQg
c21hcnQgLi4uCldoeSBkbyB3ZSBuZWVkIHRpbWUgYm91bmRlZD8gdXNlZCByaW5nIGlzIGFsd2F5
cyB1cGRhdGVkIHdoZW4gcmluZwpiZWNvbWVzIGVtcHR5LgoKPiBCdHcsIG1heWJlIGl0J3MgdGlt
ZSBqdXN0IGVuYWJsZSBuYXBpIFRYIGJ5IGRlZmF1bHQuIEkgZ2V0IH4xMCUgVENQX1JSCj4gcmVn
cmVzc2lvbiBvbiBtYWNoaW5lIHdpdGhvdXQgQVBJQ3YsIChoYXZlbid0IGZvdW5kIHRpbWUgdG8g
dGVzdCBBUElDdgo+IG1hY2hpbmUpLiBCdXQgY29uc2lkZXIgaXQgd2FzIGZvciBjb3JyZWN0bmVz
cywgSSB0aGluayBpdCdzIGFjY2VwdGFibGU/IFRoZW4KPiB3ZSBjYW4gZG8gb3B0aW1pemF0aW9u
IG9uIHRvcD8KPiAKPiAKPiBUaGFua3MKPiAKPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1pY2hhZWwg
Uy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+Cj4gPiAtLS0KPiA+ICAgZHJpdmVycy9uZXQvdmly
dGlvX25ldC5jIHwgMjcgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gPiAgIDEgZmlsZSBj
aGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5j
Cj4gPiBpbmRleCBjZWNmZDc3YzlmM2MuLmI2NTdiZGU2Yjk0YiAxMDA2NDQKPiA+IC0tLSBhL2Ry
aXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5j
Cj4gPiBAQCAtMTMyNSw3ICsxMzI1LDggQEAgc3RhdGljIGludCB2aXJ0bmV0X3JlY2VpdmUoc3Ry
dWN0IHJlY2VpdmVfcXVldWUgKnJxLCBpbnQgYnVkZ2V0LAo+ID4gICAJcmV0dXJuIHN0YXRzLnBh
Y2tldHM7Cj4gPiAgIH0KPiA+IC1zdGF0aWMgdm9pZCBmcmVlX29sZF94bWl0X3NrYnMoc3RydWN0
IHNlbmRfcXVldWUgKnNxKQo+ID4gK3N0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ticyhzdHJ1
Y3Qgc2VuZF9xdWV1ZSAqc3EsIHN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSwKPiA+ICsJCQkgICAg
ICAgYm9vbCB1c2VfbmFwaSkKPiA+ICAgewo+ID4gICAJc3RydWN0IHNrX2J1ZmYgKnNrYjsKPiA+
ICAgCXVuc2lnbmVkIGludCBsZW47Cj4gPiBAQCAtMTM0Nyw2ICsxMzQ4LDkgQEAgc3RhdGljIHZv
aWQgZnJlZV9vbGRfeG1pdF9za2JzKHN0cnVjdCBzZW5kX3F1ZXVlICpzcSkKPiA+ICAgCWlmICgh
cGFja2V0cykKPiA+ICAgCQlyZXR1cm47Cj4gPiArCWlmICh1c2VfbmFwaSkKPiA+ICsJCW5ldGRl
dl90eF9jb21wbGV0ZWRfcXVldWUodHhxLCBwYWNrZXRzLCBieXRlcyk7Cj4gPiArCj4gPiAgIAl1
NjRfc3RhdHNfdXBkYXRlX2JlZ2luKCZzcS0+c3RhdHMuc3luY3ApOwo+ID4gICAJc3EtPnN0YXRz
LmJ5dGVzICs9IGJ5dGVzOwo+ID4gICAJc3EtPnN0YXRzLnBhY2tldHMgKz0gcGFja2V0czsKPiA+
IEBAIC0xMzY0LDcgKzEzNjgsNyBAQCBzdGF0aWMgdm9pZCB2aXJ0bmV0X3BvbGxfY2xlYW50eChz
dHJ1Y3QgcmVjZWl2ZV9xdWV1ZSAqcnEpCj4gPiAgIAkJcmV0dXJuOwo+ID4gICAJaWYgKF9fbmV0
aWZfdHhfdHJ5bG9jayh0eHEpKSB7Cj4gPiAtCQlmcmVlX29sZF94bWl0X3NrYnMoc3EpOwo+ID4g
KwkJZnJlZV9vbGRfeG1pdF9za2JzKHNxLCB0eHEsIHRydWUpOwo+ID4gICAJCV9fbmV0aWZfdHhf
dW5sb2NrKHR4cSk7Cj4gPiAgIAl9Cj4gPiBAQCAtMTQ0MCw3ICsxNDQ0LDcgQEAgc3RhdGljIGlu
dCB2aXJ0bmV0X3BvbGxfdHgoc3RydWN0IG5hcGlfc3RydWN0ICpuYXBpLCBpbnQgYnVkZ2V0KQo+
ID4gICAJc3RydWN0IG5ldGRldl9xdWV1ZSAqdHhxID0gbmV0ZGV2X2dldF90eF9xdWV1ZSh2aS0+
ZGV2LCB2cTJ0eHEoc3EtPnZxKSk7Cj4gPiAgIAlfX25ldGlmX3R4X2xvY2sodHhxLCByYXdfc21w
X3Byb2Nlc3Nvcl9pZCgpKTsKPiA+IC0JZnJlZV9vbGRfeG1pdF9za2JzKHNxKTsKPiA+ICsJZnJl
ZV9vbGRfeG1pdF9za2JzKHNxLCB0eHEsIHRydWUpOwo+ID4gICAJX19uZXRpZl90eF91bmxvY2so
dHhxKTsKPiA+ICAgCXZpcnRxdWV1ZV9uYXBpX2NvbXBsZXRlKG5hcGksIHNxLT52cSwgMCk7Cj4g
PiBAQCAtMTUwNSwxMyArMTUwOSwxNSBAQCBzdGF0aWMgbmV0ZGV2X3R4X3Qgc3RhcnRfeG1pdChz
dHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgbmV0X2RldmljZSAqZGV2KQo+ID4gICAJc3RydWN0
IHNlbmRfcXVldWUgKnNxID0gJnZpLT5zcVtxbnVtXTsKPiA+ICAgCWludCBlcnI7Cj4gPiAgIAlz
dHJ1Y3QgbmV0ZGV2X3F1ZXVlICp0eHEgPSBuZXRkZXZfZ2V0X3R4X3F1ZXVlKGRldiwgcW51bSk7
Cj4gPiAtCWJvb2wga2ljayA9ICFza2ItPnhtaXRfbW9yZTsKPiA+ICsJYm9vbCBtb3JlID0gc2ti
LT54bWl0X21vcmU7Cj4gPiAgIAlib29sIHVzZV9uYXBpID0gc3EtPm5hcGkud2VpZ2h0Owo+ID4g
Kwl1bnNpZ25lZCBpbnQgYnl0ZXMgPSBza2ItPmxlbjsKPiA+ICsJYm9vbCBraWNrOwo+ID4gICAJ
LyogRnJlZSB1cCBhbnkgcGVuZGluZyBvbGQgYnVmZmVycyBiZWZvcmUgcXVldWVpbmcgbmV3IG9u
ZXMuICovCj4gPiAtCWZyZWVfb2xkX3htaXRfc2ticyhzcSk7Cj4gPiArCWZyZWVfb2xkX3htaXRf
c2ticyhzcSwgdHhxLCB1c2VfbmFwaSk7Cj4gPiAtCWlmICh1c2VfbmFwaSAmJiBraWNrKQo+ID4g
KwlpZiAodXNlX25hcGkgJiYgIW1vcmUpCj4gPiAgIAkJdmlydHF1ZXVlX2VuYWJsZV9jYl9kZWxh
eWVkKHNxLT52cSk7Cj4gPiAgIAkvKiB0aW1lc3RhbXAgcGFja2V0IGluIHNvZnR3YXJlICovCj4g
PiBAQCAtMTU1Miw3ICsxNTU4LDcgQEAgc3RhdGljIG5ldGRldl90eF90IHN0YXJ0X3htaXQoc3Ry
dWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG5ldF9kZXZpY2UgKmRldikKPiA+ICAgCQlpZiAoIXVz
ZV9uYXBpICYmCj4gPiAgIAkJICAgIHVubGlrZWx5KCF2aXJ0cXVldWVfZW5hYmxlX2NiX2RlbGF5
ZWQoc3EtPnZxKSkpIHsKPiA+ICAgCQkJLyogTW9yZSBqdXN0IGdvdCB1c2VkLCBmcmVlIHRoZW0g
dGhlbiByZWNoZWNrLiAqLwo+ID4gLQkJCWZyZWVfb2xkX3htaXRfc2ticyhzcSk7Cj4gPiArCQkJ
ZnJlZV9vbGRfeG1pdF9za2JzKHNxLCB0eHEsIGZhbHNlKTsKPiA+ICAgCQkJaWYgKHNxLT52cS0+
bnVtX2ZyZWUgPj0gMitNQVhfU0tCX0ZSQUdTKSB7Cj4gPiAgIAkJCQluZXRpZl9zdGFydF9zdWJx
dWV1ZShkZXYsIHFudW0pOwo+ID4gICAJCQkJdmlydHF1ZXVlX2Rpc2FibGVfY2Ioc3EtPnZxKTsK
PiA+IEBAIC0xNTYwLDcgKzE1NjYsMTIgQEAgc3RhdGljIG5ldGRldl90eF90IHN0YXJ0X3htaXQo
c3RydWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG5ldF9kZXZpY2UgKmRldikKPiA+ICAgCQl9Cj4g
PiAgIAl9Cj4gPiAtCWlmIChraWNrIHx8IG5ldGlmX3htaXRfc3RvcHBlZCh0eHEpKSB7Cj4gPiAr
CWlmICh1c2VfbmFwaSkKPiA+ICsJCWtpY2sgPSBfX25ldGRldl90eF9zZW50X3F1ZXVlKHR4cSwg
Ynl0ZXMsIG1vcmUpOwo+ID4gKwllbHNlCj4gPiArCQlraWNrID0gIW1vcmUgfHwgbmV0aWZfeG1p
dF9zdG9wcGVkKHR4cSk7Cj4gPiArCj4gPiArCWlmIChraWNrKSB7Cj4gPiAgIAkJaWYgKHZpcnRx
dWV1ZV9raWNrX3ByZXBhcmUoc3EtPnZxKSAmJiB2aXJ0cXVldWVfbm90aWZ5KHNxLT52cSkpIHsK
PiA+ICAgCQkJdTY0X3N0YXRzX3VwZGF0ZV9iZWdpbigmc3EtPnN0YXRzLnN5bmNwKTsKPiA+ICAg
CQkJc3EtPnN0YXRzLmtpY2tzKys7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBs
aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v
cmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==