From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipv6/route: Add a missing check on proc_dointvec Date: Thu, 27 Dec 2018 16:18:25 -0800 (PST) Message-ID: <20181227.161825.582087596488298445.davem@davemloft.net> References: <20181224163017.17362-1-pakki001@umn.edu> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kjlu@umn.edu, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: pakki001@umn.edu Return-path: In-Reply-To: <20181224163017.17362-1-pakki001@umn.edu> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Aditya Pakki Date: Mon, 24 Dec 2018 10:30:17 -0600 > While flushing the cache via ipv6_sysctl_rtcache_flush(), the call > to proc_dointvec() may fail. The fix adds a check that returns the > error, on failure. > > Signed-off-by: Aditya Pakki Applied, but honestly running garbage collection even if the value isn't change is completely harmless.