From: David Miller <davem@davemloft.net>
To: kjlu@umn.edu
Cc: pakki001@umn.edu, linux-net-drivers@solarflare.com,
ecree@solarflare.com, bkenward@solarflare.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfc: checks status of efx_mcdi_rpc
Date: Thu, 27 Dec 2018 16:25:50 -0800 (PST) [thread overview]
Message-ID: <20181227.162550.173701726860933882.davem@davemloft.net> (raw)
In-Reply-To: <20181226050517.74381-1-kjlu@umn.edu>
From: Kangjie Lu <kjlu@umn.edu>
Date: Tue, 25 Dec 2018 23:05:17 -0600
> efx_mcdi_rpc() could fail. The fix checks its status and issues an error
> message if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/ethernet/sfc/mcdi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
> index dfad93fca0a6..9486e6534dea 100644
> --- a/drivers/net/ethernet/sfc/mcdi.c
> +++ b/drivers/net/ethernet/sfc/mcdi.c
> @@ -1819,6 +1819,9 @@ void efx_mcdi_set_id_led(struct efx_nic *efx, enum efx_led_mode mode)
>
> rc = efx_mcdi_rpc(efx, MC_CMD_SET_ID_LED, inbuf, sizeof(inbuf),
> NULL, 0, NULL);
> + if (rc)
> + netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n",
> + __func__, rc);
"__func__" did not fail, efx_mcdi_rpc() did.
next prev parent reply other threads:[~2018-12-28 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 5:05 [PATCH] net: sfc: checks status of efx_mcdi_rpc Kangjie Lu
2018-12-28 0:25 ` David Miller [this message]
2019-01-02 9:26 ` Bert Kenward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227.162550.173701726860933882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bkenward@solarflare.com \
--cc=ecree@solarflare.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).