netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] configure: Fix to minor error caused by recent code cleanup
@ 2018-12-27 13:18 Firas Khalil Khana
  2019-01-01  6:00 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Firas Khalil Khana @ 2018-12-27 13:18 UTC (permalink / raw)
  To: netdev; +Cc: Firas Khalil Khana

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index b85eb58b..45fcffb6 100755
--- a/configure
+++ b/configure
@@ -115,7 +115,7 @@ EOF
 check_xt_old_internal_h()
 {
     # bail if previous XT checks has already succeeded.
-    grep -q if grep -q TC_CONFIG_XT $CONFIG && return
+    grep -q TC_CONFIG_XT $CONFIG && return
 
     #check if we need our own internal.h
     cat >$TMPDIR/ipttest.c <<EOF
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] configure: Fix to minor error caused by recent code cleanup
  2018-12-27 13:18 [PATCH] configure: Fix to minor error caused by recent code cleanup Firas Khalil Khana
@ 2019-01-01  6:00 ` Stephen Hemminger
  2019-01-01 10:58   ` DOTSLASHLINUX .
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2019-01-01  6:00 UTC (permalink / raw)
  To: Firas Khalil Khana; +Cc: netdev

On Thu, 27 Dec 2018 15:18:51 +0200
Firas Khalil Khana <firasuke@gmail.com> wrote:

I want to take this patch, but it is missing the Signed-Off-by: required
for this project.

Also please add:

Fixes: 377a09902a57 ("configure: Minor code cleanup")

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] configure: Fix to minor error caused by recent code cleanup
  2019-01-01  6:00 ` Stephen Hemminger
@ 2019-01-01 10:58   ` DOTSLASHLINUX .
  0 siblings, 0 replies; 3+ messages in thread
From: DOTSLASHLINUX . @ 2019-01-01 10:58 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

Ok, I will check.

On Tue, Jan 1, 2019 at 8:00 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 27 Dec 2018 15:18:51 +0200
> Firas Khalil Khana <firasuke@gmail.com> wrote:
>
> I want to take this patch, but it is missing the Signed-Off-by: required
> for this project.
>
> Also please add:
>
> Fixes: 377a09902a57 ("configure: Minor code cleanup")

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-01 10:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-27 13:18 [PATCH] configure: Fix to minor error caused by recent code cleanup Firas Khalil Khana
2019-01-01  6:00 ` Stephen Hemminger
2019-01-01 10:58   ` DOTSLASHLINUX .

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).