From: David Miller <davem@davemloft.net>
To: xuechaojing@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com,
tony.qu@huawei.com, luoshaokai@huawei.com
Subject: Re: [PATCH 1/1] net-next/hinic:add shutdown callback
Date: Fri, 28 Dec 2018 21:49:05 -0800 (PST) [thread overview]
Message-ID: <20181228.214905.2208487974538707696.davem@davemloft.net> (raw)
In-Reply-To: <20181228002040.1256-1-xuechaojing@huawei.com>
From: Xue Chaojing <xuechaojing@huawei.com>
Date: Fri, 28 Dec 2018 00:20:40 +0000
> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
> dev_info(&pdev->dev, "HiNIC driver - removed\n");
> }
>
> +static void hinic_shutdown(struct pci_dev *pdev)
> +{
> + pci_disable_device(pdev);
> +
> + dev_info(&pdev->dev, "HiNIC driver - shutdown\n");
> +}
I do not think these messages are appropriate. I didn't catch
them before, but I'm not going to let new ones get added.
next prev parent reply other threads:[~2018-12-29 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 0:20 [PATCH 1/1] net-next/hinic:add shutdown callback Xue Chaojing
2018-12-29 5:49 ` David Miller [this message]
2018-12-29 9:20 ` 答复: " xuechaojing
2018-12-29 16:41 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-01-01 19:39 Xue Chaojing
2019-01-02 18:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228.214905.2208487974538707696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chiqijun@huawei.com \
--cc=fy.wang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=tony.qu@huawei.com \
--cc=wulike1@huawei.com \
--cc=xuechaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).