From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <hancock@sedsystems.ca>
Cc: netdev@vger.kernel.org, arkadis@mellanox.com
Subject: Re: Errors enabling bridge with KSZ9897 DSA switch driver
Date: Fri, 28 Dec 2018 09:48:54 +0100 [thread overview]
Message-ID: <20181228084854.GA31460@lunn.ch> (raw)
In-Reply-To: <21578ba2-e8ac-2921-80d5-cd32bc1e4700@sedsystems.ca>
> FYI, changing the code in question to return 0 instead of -EOPNOTSUPP in
> the missing brport_flags_support flag case allows systemd-networkd to
> initialize the port successfully. We have some other issues in our
> hardware setup that prevent me from testing that fully at the moment,
> but I will likely submit that as a patch shortly unless I hear of a
> better solution..
Please wait until after new years when i get chance to look at this.
If you can get the supported flags, it seems odd to then ignore errors
when asked to enable something which is not supported. Either these
need to be mandatory, or systemd-networkd needs to ask before setting.
Andrew
prev parent reply other threads:[~2018-12-28 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 2:29 Errors enabling bridge with KSZ9897 DSA switch driver Robert Hancock
2018-12-23 4:47 ` Robert Hancock
2018-12-23 11:23 ` Andrew Lunn
2018-12-23 19:29 ` Robert Hancock
2018-12-23 20:57 ` Andrew Lunn
2018-12-27 23:32 ` Robert Hancock
2018-12-28 8:48 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228084854.GA31460@lunn.ch \
--to=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=hancock@sedsystems.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).