From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: Errors enabling bridge with KSZ9897 DSA switch driver Date: Fri, 28 Dec 2018 09:48:54 +0100 Message-ID: <20181228084854.GA31460@lunn.ch> References: <458c96a6-d872-3c0c-ebb0-37d505c95a76@sedsystems.ca> <20181223112332.GH32178@lunn.ch> <20181223205734.GG2791@lunn.ch> <21578ba2-e8ac-2921-80d5-cd32bc1e4700@sedsystems.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, arkadis@mellanox.com To: Robert Hancock Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:58355 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729704AbeL1Is5 (ORCPT ); Fri, 28 Dec 2018 03:48:57 -0500 Content-Disposition: inline In-Reply-To: <21578ba2-e8ac-2921-80d5-cd32bc1e4700@sedsystems.ca> Sender: netdev-owner@vger.kernel.org List-ID: > FYI, changing the code in question to return 0 instead of -EOPNOTSUPP in > the missing brport_flags_support flag case allows systemd-networkd to > initialize the port successfully. We have some other issues in our > hardware setup that prevent me from testing that fully at the moment, > but I will likely submit that as a patch shortly unless I hear of a > better solution.. Please wait until after new years when i get chance to look at this. If you can get the supported flags, it seems odd to then ignore errors when asked to enable something which is not supported. Either these need to be mandatory, or systemd-networkd needs to ask before setting. Andrew