From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH RFC net-next 19/19] devlink: Add Documentation/networking/devlink-health.txt Date: Mon, 31 Dec 2018 17:47:35 -0800 Message-ID: <20181231174735.4211d5e5@cakuba.hsd1.ca.comcast.net> References: <1546266733-9512-1-git-send-email-eranbe@mellanox.com> <1546266733-9512-20-git-send-email-eranbe@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" , Jiri Pirko , Moshe Shemesh , Aya Levin , Tal Alon , Ariel Almog To: Eran Ben Elisha Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:46223 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728722AbfAABrj (ORCPT ); Mon, 31 Dec 2018 20:47:39 -0500 Received: by mail-pg1-f193.google.com with SMTP id w7so13164410pgp.13 for ; Mon, 31 Dec 2018 17:47:39 -0800 (PST) In-Reply-To: <1546266733-9512-20-git-send-email-eranbe@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 31 Dec 2018 16:32:13 +0200, Eran Ben Elisha wrote: > +Once an error is reported, devlink health will do the following actions: > + * A log is being send to the kernel trace events buffer > + * Health status and statistics are being updated for the reporter instance > + * Object dump is being taken and saved at the reporter instance (as long as > + there is no other Objdump which is already stored) > + * Auto recovery attempt is being done. Depends on: > + - Auto-recovery configuration > + - Grace period vs. time passed since last recover Would it make sense to store the result of last recovery if it failed?