From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, petrm@mellanox.com, jiri@mellanox.com,
mlxsw@mellanox.com
Subject: Re: [PATCH net-next 1/3] net: ipv6: Introduce ip6_multipath_hash_policy()
Date: Sun, 11 Mar 2018 20:12:17 -0600 [thread overview]
Message-ID: <20187fe9-bd4b-c1d9-acfc-0bf65a23077e@gmail.com> (raw)
In-Reply-To: <20180311074549.14112-2-idosch@mellanox.com>
On 3/11/18 12:45 AM, Ido Schimmel wrote:
> From: Petr Machata <petrm@mellanox.com>
>
> In order to abstract away access to the
> ipv6.sysctl.multipath_hash_policy variable, which is not available on
> systems compiled without IPv6 support, introduce a wrapper function
> ip6_multipath_hash_policy() that falls back to 0 on non-IPv6 systems.
>
> Use this wrapper from mlxsw/spectrum_router instead of a direct
> reference.
>
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
> include/net/ipv6.h | 11 +++++++++++
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
Acked-by: David Ahern <dsahern@gmail.com>
For consistency, would be good to use that inline everywhere the sysctl
is referenced.
next prev parent reply other threads:[~2018-03-12 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 7:45 [PATCH net-next 0/3] mlxsw: Removing dependency of mlxsw on GRE Ido Schimmel
2018-03-11 7:45 ` [PATCH net-next 1/3] net: ipv6: Introduce ip6_multipath_hash_policy() Ido Schimmel
2018-03-12 2:12 ` David Ahern [this message]
2018-03-11 7:45 ` [PATCH net-next 2/3] mlxsw: spectrum: Move mlxsw_sp_span_gretap4_route() Ido Schimmel
2018-03-11 7:45 ` [PATCH net-next 3/3] mlxsw: spectrum: Don't depend on ip_gre and ip6_gre Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20187fe9-bd4b-c1d9-acfc-0bf65a23077e@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).