From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:37870 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbeCLCMS (ORCPT ); Sun, 11 Mar 2018 22:12:18 -0400 Received: by mail-pl0-f68.google.com with SMTP id w12-v6so8507418plp.4 for ; Sun, 11 Mar 2018 19:12:18 -0700 (PDT) Subject: Re: [PATCH net-next 1/3] net: ipv6: Introduce ip6_multipath_hash_policy() To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, petrm@mellanox.com, jiri@mellanox.com, mlxsw@mellanox.com References: <20180311074549.14112-1-idosch@mellanox.com> <20180311074549.14112-2-idosch@mellanox.com> From: David Ahern Message-ID: <20187fe9-bd4b-c1d9-acfc-0bf65a23077e@gmail.com> Date: Sun, 11 Mar 2018 20:12:17 -0600 MIME-Version: 1.0 In-Reply-To: <20180311074549.14112-2-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/11/18 12:45 AM, Ido Schimmel wrote: > From: Petr Machata > > In order to abstract away access to the > ipv6.sysctl.multipath_hash_policy variable, which is not available on > systems compiled without IPv6 support, introduce a wrapper function > ip6_multipath_hash_policy() that falls back to 0 on non-IPv6 systems. > > Use this wrapper from mlxsw/spectrum_router instead of a direct > reference. > > Signed-off-by: Petr Machata > Signed-off-by: Ido Schimmel > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- > include/net/ipv6.h | 11 +++++++++++ > 2 files changed, 12 insertions(+), 1 deletion(-) > Acked-by: David Ahern For consistency, would be good to use that inline everywhere the sysctl is referenced.