From: Andrew Lunn <andrew@lunn.ch>
To: Murali Krishna Policharla <murali.policharla@broadcom.com>
Cc: davem@davemloft.net, amritha.nambiar@intel.com,
ecree@solarflare.com, ktkhai@virtuozzo.com,
alexander.h.duyck@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: core: Fix to store new mtu setting in netdevice.
Date: Wed, 2 Jan 2019 00:24:43 +0100 [thread overview]
Message-ID: <20190101232443.GA22737@lunn.ch> (raw)
In-Reply-To: <30ecb54251911d28c50b61299b0f8d3d@mail.gmail.com>
On Tue, Jan 01, 2019 at 03:18:51PM +0530, Murali Krishna Policharla wrote:
> Hi Andrew,
> Currently net/dsa/slave.c does not have
> ndo_change_mtu function. But shortly I will be submitting a separate
> patch outside this fix that has ndo_change_mtu function support added to
> DSA switch. As part of testing the newly added ndo_change_mtu function
> for DSA switch it uncovered that new mtu size is not being updated to
> netdevice structure. This patch fixes this issue and updates new mtu size
> to netdevice structure.
>
> Hope this clarifies, let me know if you need any further information.
Hi Murali
Thanks for the explanation.
However, i looked at the patch you listed as 'fixes'. I don't see what
came before that setting the mtu when an ndo_change_mtu function is
provided. It seems to me, if you provide an ndo_change_mtu, it has to
do the assignment. I don't think you are fixing anything here.
If you do want to move the assignment into the core, please review all
the MAC drivers which implement ndo_change_mtu and remove the
assignment from them.
Thanks
Andrew
next prev parent reply other threads:[~2019-01-01 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 6:42 [PATCH] net: core: Fix to store new mtu setting in netdevice Murali Krishna Policharla
2019-01-01 7:54 ` Kirill Tkhai
2019-01-01 9:40 ` Heiner Kallweit
2019-01-01 23:36 ` Andrew Lunn
2019-01-02 6:27 ` Heiner Kallweit
2019-01-01 8:34 ` Andrew Lunn
2019-01-01 9:48 ` Murali Krishna Policharla
2019-01-01 23:24 ` Andrew Lunn [this message]
2019-01-02 9:54 ` Murali Krishna Policharla
2019-01-02 13:16 ` Andrew Lunn
2019-01-03 9:54 ` Murali Krishna Policharla
2019-01-01 9:35 ` Heiner Kallweit
2019-01-01 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190101232443.GA22737@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=murali.policharla@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).