From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: core: Fix to store new mtu setting in netdevice. Date: Wed, 2 Jan 2019 00:24:43 +0100 Message-ID: <20190101232443.GA22737@lunn.ch> References: <1546324934-17555-1-git-send-email-murali.policharla@broadcom.com> <20190101083450.GA17613@lunn.ch> <30ecb54251911d28c50b61299b0f8d3d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, amritha.nambiar@intel.com, ecree@solarflare.com, ktkhai@virtuozzo.com, alexander.h.duyck@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Murali Krishna Policharla Return-path: Content-Disposition: inline In-Reply-To: <30ecb54251911d28c50b61299b0f8d3d@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Jan 01, 2019 at 03:18:51PM +0530, Murali Krishna Policharla wrote: > Hi Andrew, > Currently net/dsa/slave.c does not have > ndo_change_mtu function. But shortly I will be submitting a separate > patch outside this fix that has ndo_change_mtu function support added to > DSA switch. As part of testing the newly added ndo_change_mtu function > for DSA switch it uncovered that new mtu size is not being updated to > netdevice structure. This patch fixes this issue and updates new mtu size > to netdevice structure. > > Hope this clarifies, let me know if you need any further information. Hi Murali Thanks for the explanation. However, i looked at the patch you listed as 'fixes'. I don't see what came before that setting the mtu when an ndo_change_mtu function is provided. It seems to me, if you provide an ndo_change_mtu, it has to do the assignment. I don't think you are fixing anything here. If you do want to move the assignment into the core, please review all the MAC drivers which implement ndo_change_mtu and remove the assignment from them. Thanks Andrew