From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: core: Fix to store new mtu setting in netdevice. Date: Wed, 2 Jan 2019 00:36:08 +0100 Message-ID: <20190101233608.GC22737@lunn.ch> References: <1546324934-17555-1-git-send-email-murali.policharla@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kirill Tkhai , Murali Krishna Policharla , "davem@davemloft.net" , "amritha.nambiar@intel.com" , "ecree@solarflare.com" , "alexander.h.duyck@intel.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Heiner Kallweit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > > Is there a .ndo_change_mtu callback, which does not assign a new mtu itself? > > > So far all drivers have to do it themselves. But IMO this is more a workaround > for the core not doing it. It's something the core should do. > Now we can remove this from drivers. Hi Heiner I think somebody first needs to review all the ndo_change_mtu implementations and check that none do something funny like round to multiple of 2 or 4 to satisfy DMA restrictions, etc. If there is such a thing, we cannot easily move this into the core. Andrew