From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 1/2] virtio-net: bql support Date: Wed, 2 Jan 2019 08:59:30 -0500 Message-ID: <20190102085457-mutt-send-email-mst@kernel.org> References: <20181205225323.12555-1-mst@redhat.com> <20181205225323.12555-2-mst@redhat.com> <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> <20181226101528-mutt-send-email-mst@kernel.org> <0fa99d9b-e510-d7eb-db1b-831bd7610ce9@redhat.com> <20181230134106-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, maxime.coquelin@redhat.com, wexu@redhat.com, "David S. Miller" To: Jason Wang Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org T24gV2VkLCBKYW4gMDIsIDIwMTkgYXQgMTE6Mjg6NDNBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzMxIOS4iuWNiDI6NDUsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIFRodSwgRGVjIDI3LCAyMDE4IGF0IDA2OjAwOjM2UE0gKzA4MDAsIEphc29uIFdh bmcgd3JvdGU6Cj4gPiA+IE9uIDIwMTgvMTIvMjYg5LiL5Y2IMTE6MTksIE1pY2hhZWwgUy4gVHNp cmtpbiB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIERlYyAwNiwgMjAxOCBhdCAwNDoxNzozNlBNICsw ODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ID4gT24gMjAxOC8xMi82IOS4iuWNiDY6NTQs IE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiA+ID4gV2hlbiB1c2VfbmFwaSBpcyBz ZXQsIGxldCdzIGVuYWJsZSBCUUxzLiAgTm90ZTogc29tZSBvZiB0aGUgaXNzdWVzIGFyZQo+ID4g PiA+ID4gPiBzaW1pbGFyIHRvIHdpZmkuICBJdCdzIHdvcnRoIGNvbnNpZGVyaW5nIHdoZXRoZXIg c29tZXRoaW5nIHNpbWlsYXIgdG8KPiA+ID4gPiA+ID4gY29tbWl0IDM2MTQ4YzJiYmZiZSAoIm1h YzgwMjExOiBBZGp1c3QgVFNRIHBhY2luZyBzaGlmdCIpIG1pZ2h0IGJlCj4gPiA+ID4gPiA+IGJl bmVmaXRpYWwuCj4gPiA+ID4gPiBJJ3ZlIHBsYXllZCBhIHNpbWlsYXIgcGF0Y2ggc2V2ZXJhbCBk YXlzIGJlZm9yZS4gVGhlIHRyaWNreSBwYXJ0IGlzIHRoZSBtb2RlCj4gPiA+ID4gPiBzd2l0Y2hp bmcgYmV0d2VlbiBuYXBpIGFuZCBubyBuYXBpLiBXZSBzaG91bGQgbWFrZSBzdXJlIHdoZW4gdGhl IHBhY2tldCBpcwo+ID4gPiA+ID4gc2VudCBhbmQgdHJha2NlZCBieSBCUUwswqAgaXQgc2hvdWxk IGJlIGNvbnN1bWVkIGJ5IEJRTCBhcyB3ZWxsLiBJIGRpZCBpdCBieQo+ID4gPiA+ID4gdHJhY2tp bmcgaXQgdGhyb3VnaCBza2ItPmNiLsKgIEFuZCBkZWFsIHdpdGggdGhlIGZyZWV6ZSBieSByZXNl dCB0aGUgQlFMCj4gPiA+ID4gPiBzdGF0dXMuIFBhdGNoIGF0dGFjaGVkLgo+ID4gPiA+ID4gCj4g PiA+ID4gPiBCdXQgd2hlbiB0ZXN0aW5nIHdpdGggdmhvc3QtbmV0LCBJIGRvbid0IHZlcnkgYSBz dGFibGUgcGVyZm9ybWFuY2UsCj4gPiA+ID4gU28gaG93IGFib3V0IGluY3JlYXNpbmcgVFNRIHBh Y2luZyBzaGlmdCB0aGVuPwo+ID4gPiAKPiA+ID4gSSBjYW4gdGVzdCB0aGlzLiBCdXQgY2hhbmdp bmcgZGVmYXVsdCBUQ1AgdmFsdWUgaXMgbXVjaCBtb3JlIHRoYW4gYQo+ID4gPiB2aXJ0aW8tbmV0 IHNwZWNpZmljIHRoaW5nLgo+ID4gV2VsbCBzYW1lIGxvZ2ljIGFzIHdpZmkgYXBwbGllcy4gVW5w cmVkaWN0YWJsZSBsYXRlbmNpZXMgcmVsYXRlZAo+ID4gdG8gcmFkaW8gaW4gb25lIGNhc2UsIHRv IGhvc3Qgc2NoZWR1bGVyIGluIHRoZSBvdGhlci4KPiA+IAo+ID4gPiA+ID4gaXQgd2FzCj4gPiA+ ID4gPiBwcm9iYWJseSBiZWNhdXNlIHdlIGJhdGNoIHRoZSB1c2VkIHJpbmcgdXBkYXRpbmcgc28g dHggaW50ZXJydXB0IG1heSBjb21lCj4gPiA+ID4gPiByYW5kb21seS4gV2UgcHJvYmFibHkgbmVl ZCB0byBpbXBsZW1lbnQgdGltZSBib3VuZGVkIGNvYWxlc2NpbmcgbWVjaGFuaXNtCj4gPiA+ID4g PiB3aGljaCBjb3VsZCBiZSBjb25maWd1cmVkIGZyb20gdXNlcnNwYWNlLgo+ID4gPiA+IEkgZG9u J3QgdGhpbmsgaXQncyByZWFzb25hYmxlIHRvIGV4cGVjdCB1c2Vyc3BhY2UgdG8gYmUgdGhhdCBz bWFydCAuLi4KPiA+ID4gPiBXaHkgZG8gd2UgbmVlZCB0aW1lIGJvdW5kZWQ/IHVzZWQgcmluZyBp cyBhbHdheXMgdXBkYXRlZCB3aGVuIHJpbmcKPiA+ID4gPiBiZWNvbWVzIGVtcHR5Lgo+ID4gPiAK PiA+ID4gV2UgZG9uJ3QgYWRkIHVzZWQgd2hlbiBtZWFucyBCUUwgbWF5IG5vdCBzZWUgdGhlIGNv bnN1bWVkIHBhY2tldCBpbiB0aW1lLgo+ID4gPiBBbmQgdGhlIGRlbGF5IHZhcmllcyBiYXNlZCBv biB0aGUgd29ya2xvYWQgc2luY2Ugd2UgY291bnQgcGFja2V0cyBub3QgYnl0ZXMKPiA+ID4gb3Ig dGltZSBiZWZvcmUgZG9pbmcgdGhlIGJhdGNoZWQgdXBkYXRpbmcuCj4gPiA+IAo+ID4gPiBUaGFu a3MKPiA+IFNvcnJ5IEkgc3RpbGwgZG9uJ3QgZ2V0IGl0Lgo+ID4gV2hlbiBub3RoaW5nIGlzIG91 dHN0YW5kaW5nIHRoZW4gd2UgZG8gdXBkYXRlIHRoZSB1c2VkLgo+ID4gU28gaWYgQlFMIHN0b3Bz IHVzZXJzcGFjZSBmcm9tIHNlbmRpbmcgcGFja2V0cyB0aGVuCj4gPiB3ZSBnZXQgYW4gaW50ZXJy dXB0IGFuZCBwYWNrZXRzIHN0YXJ0IGZsb3dpbmcgYWdhaW4uCj4gCj4gCj4gWWVzLCBidXQgaG93 IGFib3V0IHRoZSBjYXNlcyBvZiBtdWx0aXBsZSBmbG93cy4gVGhhdCdzIHdoZXJlIEkgc2VlIHVu c3RhYmxlCj4gcmVzdWx0cy4KPiAKPiAKPiA+IAo+ID4gSXQgbWlnaHQgYmUgc3Vib3B0aW1hbCwg d2UgbWlnaHQgbmVlZCB0byB0dW5lIGl0IGJ1dCBJIGRvdWJ0IHJ1bm5pbmcKPiA+IHRpbWVycyBp cyBhIHNvbHV0aW9uLCB0aW1lciBpbnRlcnJ1cHRzIGNhdXNlIFZNIGV4aXRzLgo+IAo+IAo+IFBy b2JhYmx5IG5vdCBhIHRpbWVyIGJ1dCBhIHRpbWUgY291bnRlciAob3IgZXZlbnQgYnl0ZSBjb3Vu dGVyKSBpbiB2aG9zdCB0bwo+IGFkZCB1c2VkIGFuZCBzaWduYWwgZ3Vlc3QgaWYgaXQgZXhjZWVk cyBhIHZhbHVlIGluc3RlYWQgb2Ygd2FpdGluZyB0aGUKPiBudW1iZXIgb2YgcGFja2V0cy4KPiAK PiAKPiBUaGFua3MKCldlbGwgd2UgYWxyZWFkeSBoYXZlIFZIT1NUX05FVF9XRUlHSFQgLSBpcyBp dCB0b28gYmlnIHRoZW4/CgpBbmQgbWF5YmUgd2Ugc2hvdWxkIGV4cG9zZSB0aGUgIk1PUkUiIGZs YWcgaW4gdGhlIGRlc2NyaXB0b3IgLQpkbyB5b3UgdGhpbmsgdGhhdCB3aWxsIGhlbHA/CgoKCj4g Cj4gPiAKPiA+ID4gPiA+IEJ0dywgbWF5YmUgaXQncyB0aW1lIGp1c3QgZW5hYmxlIG5hcGkgVFgg YnkgZGVmYXVsdC4gSSBnZXQgfjEwJSBUQ1BfUlIKPiA+ID4gPiA+IHJlZ3Jlc3Npb24gb24gbWFj aGluZSB3aXRob3V0IEFQSUN2LCAoaGF2ZW4ndCBmb3VuZCB0aW1lIHRvIHRlc3QgQVBJQ3YKPiA+ ID4gPiA+IG1hY2hpbmUpLiBCdXQgY29uc2lkZXIgaXQgd2FzIGZvciBjb3JyZWN0bmVzcywgSSB0 aGluayBpdCdzIGFjY2VwdGFibGU/IFRoZW4KPiA+ID4gPiA+IHdlIGNhbiBkbyBvcHRpbWl6YXRp b24gb24gdG9wPwo+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoYW5rcwo+ID4gPiA+ ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWljaGFlbCBTLiBUc2ly a2luIDxtc3RAcmVkaGF0LmNvbT4KPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ICAgICBkcml2 ZXJzL25ldC92aXJ0aW9fbmV0LmMgfCAyNyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+ ID4gPiA+ID4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3Zp cnRpb19uZXQuYyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gPiA+ID4gPiBpbmRleCBj ZWNmZDc3YzlmM2MuLmI2NTdiZGU2Yjk0YiAxMDA2NDQKPiA+ID4gPiA+ID4gLS0tIGEvZHJpdmVy cy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19u ZXQuYwo+ID4gPiA+ID4gPiBAQCAtMTMyNSw3ICsxMzI1LDggQEAgc3RhdGljIGludCB2aXJ0bmV0 X3JlY2VpdmUoc3RydWN0IHJlY2VpdmVfcXVldWUgKnJxLCBpbnQgYnVkZ2V0LAo+ID4gPiA+ID4g PiAgICAgCXJldHVybiBzdGF0cy5wYWNrZXRzOwo+ID4gPiA+ID4gPiAgICAgfQo+ID4gPiA+ID4g PiAtc3RhdGljIHZvaWQgZnJlZV9vbGRfeG1pdF9za2JzKHN0cnVjdCBzZW5kX3F1ZXVlICpzcSkK PiA+ID4gPiA+ID4gK3N0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ticyhzdHJ1Y3Qgc2VuZF9x dWV1ZSAqc3EsIHN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSwKPiA+ID4gPiA+ID4gKwkJCSAgICAg ICBib29sIHVzZV9uYXBpKQo+ID4gPiA+ID4gPiAgICAgewo+ID4gPiA+ID4gPiAgICAgCXN0cnVj dCBza19idWZmICpza2I7Cj4gPiA+ID4gPiA+ICAgICAJdW5zaWduZWQgaW50IGxlbjsKPiA+ID4g PiA+ID4gQEAgLTEzNDcsNiArMTM0OCw5IEBAIHN0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ti cyhzdHJ1Y3Qgc2VuZF9xdWV1ZSAqc3EpCj4gPiA+ID4gPiA+ICAgICAJaWYgKCFwYWNrZXRzKQo+ ID4gPiA+ID4gPiAgICAgCQlyZXR1cm47Cj4gPiA+ID4gPiA+ICsJaWYgKHVzZV9uYXBpKQo+ID4g PiA+ID4gPiArCQluZXRkZXZfdHhfY29tcGxldGVkX3F1ZXVlKHR4cSwgcGFja2V0cywgYnl0ZXMp Owo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICAgICAJdTY0X3N0YXRzX3VwZGF0ZV9iZWdpbigm c3EtPnN0YXRzLnN5bmNwKTsKPiA+ID4gPiA+ID4gICAgIAlzcS0+c3RhdHMuYnl0ZXMgKz0gYnl0 ZXM7Cj4gPiA+ID4gPiA+ICAgICAJc3EtPnN0YXRzLnBhY2tldHMgKz0gcGFja2V0czsKPiA+ID4g PiA+ID4gQEAgLTEzNjQsNyArMTM2OCw3IEBAIHN0YXRpYyB2b2lkIHZpcnRuZXRfcG9sbF9jbGVh bnR4KHN0cnVjdCByZWNlaXZlX3F1ZXVlICpycSkKPiA+ID4gPiA+ID4gICAgIAkJcmV0dXJuOwo+ ID4gPiA+ID4gPiAgICAgCWlmIChfX25ldGlmX3R4X3RyeWxvY2sodHhxKSkgewo+ID4gPiA+ID4g PiAtCQlmcmVlX29sZF94bWl0X3NrYnMoc3EpOwo+ID4gPiA+ID4gPiArCQlmcmVlX29sZF94bWl0 X3NrYnMoc3EsIHR4cSwgdHJ1ZSk7Cj4gPiA+ID4gPiA+ICAgICAJCV9fbmV0aWZfdHhfdW5sb2Nr KHR4cSk7Cj4gPiA+ID4gPiA+ICAgICAJfQo+ID4gPiA+ID4gPiBAQCAtMTQ0MCw3ICsxNDQ0LDcg QEAgc3RhdGljIGludCB2aXJ0bmV0X3BvbGxfdHgoc3RydWN0IG5hcGlfc3RydWN0ICpuYXBpLCBp bnQgYnVkZ2V0KQo+ID4gPiA+ID4gPiAgICAgCXN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSA9IG5l dGRldl9nZXRfdHhfcXVldWUodmktPmRldiwgdnEydHhxKHNxLT52cSkpOwo+ID4gPiA+ID4gPiAg ICAgCV9fbmV0aWZfdHhfbG9jayh0eHEsIHJhd19zbXBfcHJvY2Vzc29yX2lkKCkpOwo+ID4gPiA+ ID4gPiAtCWZyZWVfb2xkX3htaXRfc2ticyhzcSk7Cj4gPiA+ID4gPiA+ICsJZnJlZV9vbGRfeG1p dF9za2JzKHNxLCB0eHEsIHRydWUpOwo+ID4gPiA+ID4gPiAgICAgCV9fbmV0aWZfdHhfdW5sb2Nr KHR4cSk7Cj4gPiA+ID4gPiA+ICAgICAJdmlydHF1ZXVlX25hcGlfY29tcGxldGUobmFwaSwgc3Et PnZxLCAwKTsKPiA+ID4gPiA+ID4gQEAgLTE1MDUsMTMgKzE1MDksMTUgQEAgc3RhdGljIG5ldGRl dl90eF90IHN0YXJ0X3htaXQoc3RydWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG5ldF9kZXZpY2Ug KmRldikKPiA+ID4gPiA+ID4gICAgIAlzdHJ1Y3Qgc2VuZF9xdWV1ZSAqc3EgPSAmdmktPnNxW3Fu dW1dOwo+ID4gPiA+ID4gPiAgICAgCWludCBlcnI7Cj4gPiA+ID4gPiA+ICAgICAJc3RydWN0IG5l dGRldl9xdWV1ZSAqdHhxID0gbmV0ZGV2X2dldF90eF9xdWV1ZShkZXYsIHFudW0pOwo+ID4gPiA+ ID4gPiAtCWJvb2wga2ljayA9ICFza2ItPnhtaXRfbW9yZTsKPiA+ID4gPiA+ID4gKwlib29sIG1v cmUgPSBza2ItPnhtaXRfbW9yZTsKPiA+ID4gPiA+ID4gICAgIAlib29sIHVzZV9uYXBpID0gc3Et Pm5hcGkud2VpZ2h0Owo+ID4gPiA+ID4gPiArCXVuc2lnbmVkIGludCBieXRlcyA9IHNrYi0+bGVu Owo+ID4gPiA+ID4gPiArCWJvb2wga2ljazsKPiA+ID4gPiA+ID4gICAgIAkvKiBGcmVlIHVwIGFu eSBwZW5kaW5nIG9sZCBidWZmZXJzIGJlZm9yZSBxdWV1ZWluZyBuZXcgb25lcy4gKi8KPiA+ID4g PiA+ID4gLQlmcmVlX29sZF94bWl0X3NrYnMoc3EpOwo+ID4gPiA+ID4gPiArCWZyZWVfb2xkX3ht aXRfc2ticyhzcSwgdHhxLCB1c2VfbmFwaSk7Cj4gPiA+ID4gPiA+IC0JaWYgKHVzZV9uYXBpICYm IGtpY2spCj4gPiA+ID4gPiA+ICsJaWYgKHVzZV9uYXBpICYmICFtb3JlKQo+ID4gPiA+ID4gPiAg ICAgCQl2aXJ0cXVldWVfZW5hYmxlX2NiX2RlbGF5ZWQoc3EtPnZxKTsKPiA+ID4gPiA+ID4gICAg IAkvKiB0aW1lc3RhbXAgcGFja2V0IGluIHNvZnR3YXJlICovCj4gPiA+ID4gPiA+IEBAIC0xNTUy LDcgKzE1NTgsNyBAQCBzdGF0aWMgbmV0ZGV2X3R4X3Qgc3RhcnRfeG1pdChzdHJ1Y3Qgc2tfYnVm ZiAqc2tiLCBzdHJ1Y3QgbmV0X2RldmljZSAqZGV2KQo+ID4gPiA+ID4gPiAgICAgCQlpZiAoIXVz ZV9uYXBpICYmCj4gPiA+ID4gPiA+ICAgICAJCSAgICB1bmxpa2VseSghdmlydHF1ZXVlX2VuYWJs ZV9jYl9kZWxheWVkKHNxLT52cSkpKSB7Cj4gPiA+ID4gPiA+ICAgICAJCQkvKiBNb3JlIGp1c3Qg Z290IHVzZWQsIGZyZWUgdGhlbSB0aGVuIHJlY2hlY2suICovCj4gPiA+ID4gPiA+IC0JCQlmcmVl X29sZF94bWl0X3NrYnMoc3EpOwo+ID4gPiA+ID4gPiArCQkJZnJlZV9vbGRfeG1pdF9za2JzKHNx LCB0eHEsIGZhbHNlKTsKPiA+ID4gPiA+ID4gICAgIAkJCWlmIChzcS0+dnEtPm51bV9mcmVlID49 IDIrTUFYX1NLQl9GUkFHUykgewo+ID4gPiA+ID4gPiAgICAgCQkJCW5ldGlmX3N0YXJ0X3N1YnF1 ZXVlKGRldiwgcW51bSk7Cj4gPiA+ID4gPiA+ICAgICAJCQkJdmlydHF1ZXVlX2Rpc2FibGVfY2Io c3EtPnZxKTsKPiA+ID4gPiA+ID4gQEAgLTE1NjAsNyArMTU2NiwxMiBAQCBzdGF0aWMgbmV0ZGV2 X3R4X3Qgc3RhcnRfeG1pdChzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgbmV0X2RldmljZSAq ZGV2KQo+ID4gPiA+ID4gPiAgICAgCQl9Cj4gPiA+ID4gPiA+ICAgICAJfQo+ID4gPiA+ID4gPiAt CWlmIChraWNrIHx8IG5ldGlmX3htaXRfc3RvcHBlZCh0eHEpKSB7Cj4gPiA+ID4gPiA+ICsJaWYg KHVzZV9uYXBpKQo+ID4gPiA+ID4gPiArCQlraWNrID0gX19uZXRkZXZfdHhfc2VudF9xdWV1ZSh0 eHEsIGJ5dGVzLCBtb3JlKTsKPiA+ID4gPiA+ID4gKwllbHNlCj4gPiA+ID4gPiA+ICsJCWtpY2sg PSAhbW9yZSB8fCBuZXRpZl94bWl0X3N0b3BwZWQodHhxKTsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ ID4gPiArCWlmIChraWNrKSB7Cj4gPiA+ID4gPiA+ICAgICAJCWlmICh2aXJ0cXVldWVfa2lja19w cmVwYXJlKHNxLT52cSkgJiYgdmlydHF1ZXVlX25vdGlmeShzcS0+dnEpKSB7Cj4gPiA+ID4gPiA+ ICAgICAJCQl1NjRfc3RhdHNfdXBkYXRlX2JlZ2luKCZzcS0+c3RhdHMuc3luY3ApOwo+ID4gPiA+ ID4gPiAgICAgCQkJc3EtPnN0YXRzLmtpY2tzKys7Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==