* [PATCH net] ipv6: Fix dump of specific table with strict checking
@ 2019-01-03 2:26 David Ahern
2019-01-03 4:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2019-01-03 2:26 UTC (permalink / raw)
To: davem; +Cc: jakub.kicinski, netdev, David Ahern
From: David Ahern <dsahern@gmail.com>
Dump of a specific table with strict checking enabled is looping. The
problem is that the end of the table dump is not marked in the cb. When
dumping a specific table, cb args 0 and 1 are not used (they are the hash
index and entry with an hash table index when dumping all tables). Re-use
args[0] to hold a 'done' flag for the specific table dump.
Fixes: 13e38901d46ca ("net/ipv6: Plumb support for filtering route dumps")
Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv6/ip6_fib.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index ae3786132c23..6613d8dbb0e5 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -627,7 +627,11 @@ static int inet6_dump_fib(struct sk_buff *skb, struct netlink_callback *cb)
return -ENOENT;
}
- res = fib6_dump_table(tb, skb, cb);
+ if (!cb->args[0]) {
+ res = fib6_dump_table(tb, skb, cb);
+ if (!res)
+ cb->args[0] = 1;
+ }
goto out;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] ipv6: Fix dump of specific table with strict checking
2019-01-03 2:26 [PATCH net] ipv6: Fix dump of specific table with strict checking David Ahern
@ 2019-01-03 4:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-03 4:17 UTC (permalink / raw)
To: dsahern; +Cc: jakub.kicinski, netdev, dsahern
From: David Ahern <dsahern@kernel.org>
Date: Wed, 2 Jan 2019 18:26:13 -0800
> From: David Ahern <dsahern@gmail.com>
>
> Dump of a specific table with strict checking enabled is looping. The
> problem is that the end of the table dump is not marked in the cb. When
> dumping a specific table, cb args 0 and 1 are not used (they are the hash
> index and entry with an hash table index when dumping all tables). Re-use
> args[0] to hold a 'done' flag for the specific table dump.
>
> Fixes: 13e38901d46ca ("net/ipv6: Plumb support for filtering route dumps")
> Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-03 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-03 2:26 [PATCH net] ipv6: Fix dump of specific table with strict checking David Ahern
2019-01-03 4:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).