From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Bolotin Subject: [PATCH net 2/2] qed: Fix qed_ll2_post_rx_buffer_notify_fw() by adding a write memory barrier Date: Thu, 3 Jan 2019 12:02:40 +0200 Message-ID: <20190103100240.17534-3-dbolotin@marvell.com> References: <20190103100240.17534-1-dbolotin@marvell.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Denis Bolotin To: , Return-path: Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:32820 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730589AbfACKDK (ORCPT ); Thu, 3 Jan 2019 05:03:10 -0500 In-Reply-To: <20190103100240.17534-1-dbolotin@marvell.com> Sender: netdev-owner@vger.kernel.org List-ID: Make sure chain element is updated before ringing the doorbell. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index 90afd51..d9237c6 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -1619,6 +1619,10 @@ static void qed_ll2_post_rx_buffer_notify_fw(struct qed_hwfn *p_hwfn, cq_prod = qed_chain_get_prod_idx(&p_rx->rcq_chain); rx_prod.bd_prod = cpu_to_le16(bd_prod); rx_prod.cqe_prod = cpu_to_le16(cq_prod); + + /* Make sure chain element is updated before ringing the doorbell */ + dma_wmb(); + DIRECT_REG_WR(p_rx->set_prod_addr, *((u32 *)&rx_prod)); } -- 1.8.3.1